Skip to content

add kubeClusterName to teleport-cluster helm chart#6597

Closed
timothy-spencer wants to merge 3 commits intogravitational:masterfrom
timothy-spencer:kubeclustername
Closed

add kubeClusterName to teleport-cluster helm chart#6597
timothy-spencer wants to merge 3 commits intogravitational:masterfrom
timothy-spencer:kubeclustername

Conversation

@timothy-spencer
Copy link
Copy Markdown
Contributor

add optional kube_cluster_name to try to make kubeconfig not have such a giant ugly name in it

@russjones
Copy link
Copy Markdown
Contributor

@timothy-spencer Thank you for your contribution!

@webvictim You're reworking Helm charts in #6344, can you take a look at this and see if these changes make sense in the context of new Helm charts?

@russjones russjones requested a review from webvictim April 28, 2021 21:17
@webvictim
Copy link
Copy Markdown
Contributor

@klizhentas What do you think about this? We're trying to keep the chart simple, is adding an override for this something we want to support?

@timothy-spencer
Copy link
Copy Markdown
Contributor Author

This is definitely a cosmetic change. Happy to close it if you are unhappy with it.

@russjones russjones added the ux label May 5, 2021
@webvictim
Copy link
Copy Markdown
Contributor

@timothy-spencer We'd prefer not to merge this as it adds an additional configuration value which users may find confusing and solely addresses a cosmetic issue. Having the names generated from a combination of Teleport proxy address and Kubernetes cluster name is at least predictable and easier to handle for support purposes, even if perhaps a little untidy.

Thank you for your contribution, and please feel free to raise other PRs in future!

@webvictim webvictim closed this May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants