add kubeClusterName to teleport-cluster helm chart#6597
add kubeClusterName to teleport-cluster helm chart#6597timothy-spencer wants to merge 3 commits intogravitational:masterfrom
Conversation
|
@timothy-spencer Thank you for your contribution! @webvictim You're reworking Helm charts in #6344, can you take a look at this and see if these changes make sense in the context of new Helm charts? |
|
@klizhentas What do you think about this? We're trying to keep the chart simple, is adding an override for this something we want to support? |
|
This is definitely a cosmetic change. Happy to close it if you are unhappy with it. |
|
@timothy-spencer We'd prefer not to merge this as it adds an additional configuration value which users may find confusing and solely addresses a cosmetic issue. Having the names generated from a combination of Teleport proxy address and Kubernetes cluster name is at least predictable and easier to handle for support purposes, even if perhaps a little untidy. Thank you for your contribution, and please feel free to raise other PRs in future! |
add optional kube_cluster_name to try to make kubeconfig not have such a giant ugly name in it