mfa: better OTP registration flow on CLI #6567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've DMed feedback, but
^ this worked with 1Password one-time token. |
awly
force-pushed
the
andrew/otp-register-ux
branch
3 times, most recently
from
2ecfebc to
1c50fce
Compare
benarent
approved these changes
Apr 23, 2021
Several improvements: - show a QR code in the system image viewer - print an OTP URL in addition to individual fields (some apps accept that as input) - use cluster name as `Issuer` instead of "Teleport"
awly
force-pushed
the
andrew/otp-register-ux
branch
from
1c50fce to
7dc3cb6
Compare
klizhentas
approved these changes
Apr 26, 2021
awly
pushed a commit
that referenced
this pull request
Apr 27, 2021
Several improvements: - show a QR code in the system image viewer - print an OTP URL in addition to individual fields (some apps accept that as input) - use cluster name as `Issuer` instead of "Teleport"
awly
pushed a commit
that referenced
this pull request
Apr 28, 2021
Several improvements: - show a QR code in the system image viewer - print an OTP URL in addition to individual fields (some apps accept that as input) - use cluster name as `Issuer` instead of "Teleport"
awly
pushed a commit
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements:
that as input)
Issuerinstead of "Teleport"Updates #5878
@webvictim or @benarent, if you have access to a mac, can you try
tsh mfa add --type=totpwith this PR?Does the QR code open up?