Check cloud feature before setting billing access for web #6537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimlisa
force-pushed
the
lisa/cloud-feature-flag
branch
from
ccea797 to
1993c8c
Compare
alex-kovoy
reviewed
Apr 21, 2021
kimlisa
force-pushed
the
lisa/cloud-feature-flag
branch
from
0c31d2c to
19b4199
Compare
alex-kovoy
approved these changes
Apr 22, 2021
kimlisa
force-pushed
the
lisa/cloud-feature-flag
branch
4 times, most recently
from
147f910 to
c341b6b
Compare
r0mant
reviewed
Apr 27, 2021
kimlisa
force-pushed
the
lisa/cloud-feature-flag
branch
2 times, most recently
from
c4f6194 to
7cc9a96
Compare
kimlisa
force-pushed
the
lisa/cloud-feature-flag
branch
from
7cc9a96 to
61ed3a9
Compare
r0mant
approved these changes
May 5, 2021
| if err == nil { | ||
| process.setClusterFeatures(pingResponse.GetServerFeatures()) |
There was a problem hiding this comment.
Could you please log server features loaded from auth server here? In Info mode. It would be helpful for troubleshooting, right now there's no visibility.
- Use Ping (that responds with server features) instead of GetNamespace to test c/n - Set server features for web handler (to set it once on register.proxy)
- Add lock before setting - Remove print statements
- rename authServerFeatures to clusterFeatures - defined a locked getter to retrieve cluster features - check for nil before setting
kimlisa
force-pushed
the
lisa/cloud-feature-flag
branch
from
61ed3a9 to
14fecbd
Compare
kimlisa
added a commit
that referenced
this pull request
May 5, 2021
* Init web handler with auth server feature flags on proxy init * Retrieve auth server features by calling Ping when connecting to auth svc which contains the server feature flags in the response
kimlisa
added a commit
that referenced
this pull request
May 5, 2021
* Init web handler with auth server feature flags on proxy init * Retrieve auth server features by calling Ping when connecting to auth svc which contains the server feature flags in the response
kimlisa
added a commit
that referenced
this pull request
May 5, 2021
* Init web handler with auth server feature flags on proxy init * Retrieve auth server features by calling Ping when connecting to auth svc which contains the server feature flags in the response
kimlisa
added a commit
that referenced
this pull request
May 6, 2021
…#6754) * Create GET db and kube list web handlers (#6672) * Check cloud feature before setting billing access for web (#6537) - Init web handler with auth server feature flags on proxy init - Retrieve auth server features by calling Ping when connecting to auth svc which contains the server feature flags in the response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6447
Description
Init web handler with feature flags on proxy init
Ping, which contains the server feature flags in the response