[Browser MFA] Fix formatting in moderated sessions#65236
Merged
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Author
|
@claude review once |
6dd05fe to
afc3452
Compare
afc3452 to
572148c
Compare
zmb3
approved these changes
Mar 31, 2026
juliaogris
approved these changes
Apr 1, 2026
Contributor
|
@danielashare See the table below for backport results.
|
danielashare
added a commit
that referenced
this pull request
Apr 1, 2026
danielashare
added a commit
that referenced
this pull request
Apr 2, 2026
danielashare
added a commit
that referenced
this pull request
Apr 7, 2026
danielashare
added a commit
that referenced
this pull request
Apr 17, 2026
mmcallister
pushed a commit
that referenced
this pull request
Apr 24, 2026
mmcallister
pushed a commit
that referenced
this pull request
Apr 28, 2026
danielashare
added a commit
that referenced
this pull request
Apr 30, 2026
danielashare
added a commit
that referenced
this pull request
May 5, 2026
danielashare
added a commit
that referenced
this pull request
May 6, 2026
[Browser MFA] Add protobuf and config (#63831) [Browser MFA] Add proto for Browser MFA feature (#64048) [Browser MFA] Add CompleteBrowserMFAChallenge gRPC (#63873) [Browser MFA] Rename browser mfa config name (#64980) [Browser MFA] Add BrowserMFARequestID to CreateAuthenticateChallenge (#63945) [Browser MFA] Add Browser MFA to challenge request flow (#63936) [Browser MFA] Add initial requests for browser MFA process to client tools (#64301) [Browser MFA] Add tsh callback handling for webauthn response (#64461) [Browser MFA] Add Browser MFA to presence checks (#65052) [Browser MFA] Add browser MFA path to MFA finish flow (#64523) [Browser MFA] Add Browser MFA to Connect (#64887) [Browser MFA] Add Browser MFA UI (#64692) [Browser MFA] Fix formatting in moderated sessions (#65236) [Browser MFA] Add Browser MFA ceremony tests
ivan-bax
pushed a commit
to ivan-bax/teleport
that referenced
this pull request
May 22, 2026
[Browser MFA] Add protobuf and config (gravitational#63831) [Browser MFA] Add proto for Browser MFA feature (gravitational#64048) [Browser MFA] Add CompleteBrowserMFAChallenge gRPC (gravitational#63873) [Browser MFA] Rename browser mfa config name (gravitational#64980) [Browser MFA] Add BrowserMFARequestID to CreateAuthenticateChallenge (gravitational#63945) [Browser MFA] Add Browser MFA to challenge request flow (gravitational#63936) [Browser MFA] Add initial requests for browser MFA process to client tools (gravitational#64301) [Browser MFA] Add tsh callback handling for webauthn response (gravitational#64461) [Browser MFA] Add Browser MFA to presence checks (gravitational#65052) [Browser MFA] Add browser MFA path to MFA finish flow (gravitational#64523) [Browser MFA] Add Browser MFA to Connect (gravitational#64887) [Browser MFA] Add Browser MFA UI (gravitational#64692) [Browser MFA] Fix formatting in moderated sessions (gravitational#65236) [Browser MFA] Add Browser MFA ceremony tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes formatting when printing MFA messages to the terminal.
During an interactive SSH session, like moderated SSH sessions,
tshputs the terminal in to raw mode. In raw mode, a\nonly moves the cursor down a line, not back to column 0. To fix this we have to use\r\n. This doesn't affect cooked-mode terminals.Before change:
After change:
Manual Test Plan
Test Environment
Teleport
erunning locally with moderated sessions enabled.Test Cases