Add e2e tests for state restoration in Connect by ravicious · Pull Request #64769 · gravitational/teleport

ravicious · 2026-03-18T14:49:11Z

This PR adds e2e for the state restoration section from Connect's test plan.

I skipped the items:

Verify that reopening a cluster that has no workspace assigned works.
- This requires two clusters.
Open a db connection tab. Change the db name and port. Close the tab. Restart the app. Open connection tracker and choose said db connection from it. Verify that the newly opened tab uses the same db name and port.
- This requires a db agent.

Also, #64758 made it so that usageReporting.enabled is false by default so that the app does not show the modal asking about telemetry on start. I added a separate test to verify that this modal is shown when usageReporting.enabled is not set in the config.

teleport/.github/ISSUE_TEMPLATE/webtestplan.md

Lines 958 to 977 in 770e0ec

    
           - State restoration from disk 
        
             - [ ] Verify that the app asks about restoring previous tabs when launched and restores them 
        
                   properly. 
        
             - [ ] Verify that the app opens with the cluster that was active when you closed the app. 
        
             - [ ] Verify that the app remembers size & position after restart. 
        
               - Verify that this works on: 
        
                 - [ ] macOS 
        
                 - [ ] Windows 
        
                 - [ ] Linux 
        
             - [ ] Verify that [reopening a cluster that has no workspace 
        
                   assigned](https://github.com/gravitational/webapps.e/issues/275#issuecomment-1131663575) works. 
        
             - [ ] Verify that reopening the app after removing `~/Library/Application Support/Teleport Connect/tsh` doesn't crash the app. 
        
             - [ ] Verify that reopening the app after removing `~/Library/Application Support/Teleport Connect/app_state.json` but not the `tsh` dir doesn't crash the app. 
        
             - [ ] Verify that logging out of a cluster and then logging in to the same cluster doesn't 
        
                   remember previous tabs (they should be cleared on logout). 
        
             - [ ] Open a db connection tab. Change the db name and port. Close the tab. Restart the app. Open 
        
                   connection tracker and choose said db connection from it. Verify that the newly opened tab uses 
        
                   the same db name and port. 
        
             - [ ] Log in to a cluster. Close the DocumentCluster tab. Open a new DocumentCluster tab. Restart 
        
                   the app. Verify that the app doesn't ask you about restoring previous tabs.

Manual Test Plan

Test Environment

My laptop.

Test Cases

The new tests work.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 598fdbea07

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f443df4a65

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0bcd68fb1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ae98dca226

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e6802f346b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…et in same tick

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5d82a8da1b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c051c8ad7b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75797519b9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 93041be939

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dfa5117391

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ravicious requested a review from gzdunek March 18, 2026 14:49

ravicious added the no-changelog Indicates that a PR does not require a changelog entry label Mar 18, 2026

github-actions bot added the size/md label Mar 18, 2026

github-actions bot requested review from espadolini and tcsc March 18, 2026 14:49

ravicious requested review from avatus and removed request for espadolini and tcsc March 18, 2026 14:50

chatgpt-codex-connector bot reviewed Mar 18, 2026

View reviewed changes

Comment thread e2e/tests/connect/firstLaunch.spec.ts

ravicious force-pushed the r7s/e2e-connect-state branch from 598fdbe to eef4289 Compare March 18, 2026 16:12

avatus approved these changes Mar 18, 2026

View reviewed changes

Refactor launchApp to avoid app.app callsites

2e1bcbc

ravicious force-pushed the r7s/e2e-connect-state branch from eef4289 to d34c41b Compare March 18, 2026 16:20

ravicious added 2 commits March 18, 2026 17:23

Add tests for state restoration

5ea7eef

Add test for first launch

f443df4

ravicious force-pushed the r7s/e2e-connect-state branch from d34c41b to f443df4 Compare March 18, 2026 16:24

chatgpt-codex-connector bot reviewed Mar 18, 2026

View reviewed changes

Comment thread e2e/tests/connect/stateRestoration.spec.ts Outdated

Comment thread e2e/tests/connect/stateRestoration.spec.ts Outdated

ravicious added 2 commits March 18, 2026 17:44

Preserve app_state.json for the missing-tsh restart case

1a5b00a

Choose window bounds relative to the current display

c0bcd68

chatgpt-codex-connector bot reviewed Mar 18, 2026

View reviewed changes

Comment thread e2e/tests/connect/stateRestoration.spec.ts Outdated

Comment thread e2e/tests/connect/stateRestoration.spec.ts

Account for work area, read bounds after setting them

ae98dca

chatgpt-codex-connector bot reviewed Mar 18, 2026

View reviewed changes

Comment thread e2e/tests/connect/stateRestoration.spec.ts

gzdunek approved these changes Mar 19, 2026

View reviewed changes

Assert absence of the restore modal after re-login

e6802f3

chatgpt-codex-connector bot reviewed Mar 19, 2026

View reviewed changes

Comment thread e2e/tests/connect/firstLaunch.spec.ts

Comment thread e2e/tests/connect/stateRestoration.spec.ts

ravicious added 2 commits March 19, 2026 12:44

Assert that telemetry dialog is dismissed

31eb10e

setActiveWorkspace: Test if rootClusterUri and documents-reopen are s…

5d82a8d

…et in same tick

ravicious requested a review from gzdunek March 19, 2026 15:12

chatgpt-codex-connector bot reviewed Mar 19, 2026

View reviewed changes

Comment thread e2e/tests/connect/stateRestoration.spec.ts

Disable jest/no-conditional-expect

c051c8a

chatgpt-codex-connector bot reviewed Mar 19, 2026

View reviewed changes

Comment thread e2e/tests/connect/stateRestoration.spec.ts

Assert the reopen dialog closes after restoring tabs

7579751

chatgpt-codex-connector bot reviewed Mar 19, 2026

View reviewed changes

Comment thread web/packages/teleterm/src/ui/services/workspacesService/workspacesService.test.ts

gzdunek approved these changes Mar 19, 2026

View reviewed changes

Verify that documents-reopen was called

93041be

chatgpt-codex-connector bot reviewed Mar 19, 2026

View reviewed changes

Comment thread e2e/tests/connect/stateRestoration.spec.ts

Comment thread e2e/tests/connect/stateRestoration.spec.ts

ravicious mentioned this pull request Mar 20, 2026

[v18] vnet linux support #64736

Open

8 tasks

Verify setBounds works

dfa5117

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

Comment thread e2e/tests/connect/stateRestoration.spec.ts

ravicious enabled auto-merge March 20, 2026 12:02

ravicious added this pull request to the merge queue Mar 20, 2026

Merged via the queue into master with commit 57ad0fc Mar 20, 2026
43 checks passed

ravicious deleted the r7s/e2e-connect-state branch March 20, 2026 12:20

	- State restoration from disk
	- [ ] Verify that the app asks about restoring previous tabs when launched and restores them
	properly.
	- [ ] Verify that the app opens with the cluster that was active when you closed the app.
	- [ ] Verify that the app remembers size & position after restart.
	- Verify that this works on:
	- [ ] macOS
	- [ ] Windows
	- [ ] Linux
	- [ ] Verify that [reopening a cluster that has no workspace
	assigned](https://github.com/gravitational/webapps.e/issues/275#issuecomment-1131663575) works.
	- [ ] Verify that reopening the app after removing `~/Library/Application Support/Teleport Connect/tsh` doesn't crash the app.
	- [ ] Verify that reopening the app after removing `~/Library/Application Support/Teleport Connect/app_state.json` but not the `tsh` dir doesn't crash the app.
	- [ ] Verify that logging out of a cluster and then logging in to the same cluster doesn't
	remember previous tabs (they should be cleared on logout).
	- [ ] Open a db connection tab. Change the db name and port. Close the tab. Restart the app. Open
	connection tracker and choose said db connection from it. Verify that the newly opened tab uses
	the same db name and port.
	- [ ] Log in to a cluster. Close the DocumentCluster tab. Open a new DocumentCluster tab. Restart
	the app. Verify that the app doesn't ask you about restoring previous tabs.

Conversation

ravicious commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Manual Test Plan

Test Environment

Test Cases

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ravicious commented Mar 18, 2026 •

edited

Loading