Skip to content

Tighten kinit file permissions#63916

Merged
zmb3 merged 1 commit into
masterfrom
zmb3/kinit-file-perms
Feb 18, 2026
Merged

Tighten kinit file permissions#63916
zmb3 merged 1 commit into
masterfrom
zmb3/kinit-file-perms

Conversation

@zmb3
Copy link
Copy Markdown
Collaborator

@zmb3 zmb3 commented Feb 17, 2026

The Kerberos kinit client for database access temporarily writes a certificate (and its key and corresponding CA) to a temporary directory with world-reabable (and writable) permissions.

The permissions on the parent directory are correctly restricted to the current user only, so there is no exploit possible, this change just adds defense in depth by restricting the file permissions as well.

The Kerberos kinit client for database access temporarily writes
a certificate (and its key and corresponding CA) to a temporary
directory with world-reabable (and writable) permissions.

The permissions on the parent directory are correctly restricted to
the current user only, so there is no exploit possible, this change
just adds defense in depth by restricting the file permissions as well.
@zmb3 zmb3 requested review from Tener and greedy52 February 17, 2026 23:45
@zmb3 zmb3 added backport no-changelog Indicates that a PR does not require a changelog entry labels Feb 17, 2026
@github-actions github-actions Bot added database-access Database access related issues and PRs size/sm labels Feb 17, 2026
@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from greedy52 February 18, 2026 12:50
@zmb3 zmb3 enabled auto-merge February 18, 2026 17:36
@zmb3 zmb3 added this pull request to the merge queue Feb 18, 2026
Merged via the queue into master with commit 0b101b1 Feb 18, 2026
52 of 53 checks passed
@zmb3 zmb3 deleted the zmb3/kinit-file-perms branch February 18, 2026 18:24
@backport-bot-workflows
Copy link
Copy Markdown
Contributor

@zmb3 See the table below for backport results.

Branch Result
branch/v17 Failed
branch/v18 Create PR

@zmb3
Copy link
Copy Markdown
Collaborator Author

zmb3 commented Feb 18, 2026

Looks like a v17 backport is unnecessary because this was fixed directly on branch/v17 in #55142. (That fix wasn't applied to master because the underlying issue wasn't applicable on master).

cc @Tener to make sure I've got that right.

@Tener
Copy link
Copy Markdown
Contributor

Tener commented Feb 19, 2026

Looks like a v17 backport is unnecessary because this was fixed directly on branch/v17 in #55142. (That fix wasn't applied to master because the underlying issue wasn't applicable on master).

cc @Tener to make sure I've got that right.

Yes, this is quite right.

cthach pushed a commit that referenced this pull request Feb 20, 2026
The Kerberos kinit client for database access temporarily writes
a certificate (and its key and corresponding CA) to a temporary
directory with world-reabable (and writable) permissions.

The permissions on the parent directory are correctly restricted to
the current user only, so there is no exploit possible, this change
just adds defense in depth by restricting the file permissions as well.
danielashare pushed a commit that referenced this pull request Feb 23, 2026
The Kerberos kinit client for database access temporarily writes
a certificate (and its key and corresponding CA) to a temporary
directory with world-reabable (and writable) permissions.

The permissions on the parent directory are correctly restricted to
the current user only, so there is no exploit possible, this change
just adds defense in depth by restricting the file permissions as well.
mmcallister pushed a commit that referenced this pull request Apr 28, 2026
The Kerberos kinit client for database access temporarily writes
a certificate (and its key and corresponding CA) to a temporary
directory with world-reabable (and writable) permissions.

The permissions on the parent directory are correctly restricted to
the current user only, so there is no exploit possible, this change
just adds defense in depth by restricting the file permissions as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/branch/v17 backport/branch/v18 database-access Database access related issues and PRs no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants