Merged
Conversation
ravicious
added
the
no-changelog
ravicious
commented
Jan 28, 2026
Comment on lines
+131
to
+134
| entitlements: entitlementsMacOS, | ||
| // Use the same entitlements for Electron subprocesses (e.g., renderer, GPU) | ||
| // as those defined for the main app. | ||
| entitlementsInherit: 'build_resources/entitlements.mac.plist', | ||
| entitlementsInherit: entitlementsMacOS, |
Member
Author
There was a problem hiding this comment.
These changes were discussed here: #62704 (comment)
In short, electron-builder used to not sign the app when no signing identity was present. Now it does ad-hoc signing in those cases. When an app is ad-hoc signed, it needs the com.apple.security.cs.disable-library-validation entitlement to work properly when hardened runtime is on.
This is not needed in "prod" (for both dev and prod builds) where we do provide a signing identity.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ravicious
commented
Jan 28, 2026
| # Remove previous link if it doesn't use update-alternatives | ||
| if [ -L "$BIN/${executable}" -a -e "$BIN/${executable}" -a "`readlink "$BIN/${executable}"`" != "/etc/alternatives/${executable}" ]; then | ||
| # shellcheck disable=SC2154 # This is custom electron-builder macro expansion, not Bash templating. | ||
| if [ -L "$BIN/${executable}" ] && [ -e "$BIN/${executable}" ] && [ "$(readlink "$BIN/${executable}")" != "/etc/alternatives/${executable}" ]; then |
Member
Author
There was a problem hiding this comment.
I addressed a long standing todo item about making sure that make lint-sh checks these scripts.
This was the only change that I had to apply, shellcheck was outputting this:
In ./web/packages/teleterm/build_resources/linux/after-install.sh.tmpl line 73:
if [ -L "$BIN/${executable}" -a -e "$BIN/${executable}" -a "`readlink "$BIN/${executable}"`" != "/etc/alternatives/${executable}" ]; then
^-----------^ SC2154 (warning): executable is referenced but not assigned.
^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
^-----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
if [ -L "$BIN/${executable}" -a -e "$BIN/${executable}" -a "$(readlink "$BIN/${executable}")" != "/etc/alternatives/${executable}" ]; then
ravicious
commented
Jan 28, 2026
| "@xterm/xterm": "^6.0.0", | ||
| "electron": "39.2.2", | ||
| "electron-builder": "^26.0.12", | ||
| "electron-builder": "^26.6.0", |
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
macOS, Windows, Ubuntu and Fedora versions work fine.
gzdunek
approved these changes
Jan 28, 2026
avatus
approved these changes
Jan 28, 2026
public-teleport-github-review-bot
Bot
removed the request for review
from rudream
Contributor
|
@ravicious See the table below for backport results.
|
This was referenced Jan 29, 2026
cthach
pushed a commit
that referenced
this pull request
Jan 29, 2026
* Update electron-builder to 26.6.0 * Add special entitlements for ad-hoc signed builds * Add special entitlements for main app too * Add commit hashes to Linux scripts * Check Linux scripts with shellcheck --------- Co-authored-by: Grzegorz Zdunek <grzegorz.zdunek@goteleport.com>
mmcallister
pushed a commit
that referenced
this pull request
Apr 28, 2026
* Update electron-builder to 26.6.0 * Add special entitlements for ad-hoc signed builds * Add special entitlements for main app too * Add commit hashes to Linux scripts * Check Linux scripts with shellcheck --------- Co-authored-by: Grzegorz Zdunek <grzegorz.zdunek@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Dependabot alerts about the tar package: