Merged
Conversation
gzdunek
added
no-changelog
nklaassen
approved these changes
Jan 27, 2026
ravicious
approved these changes
Jan 27, 2026
Member
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
Installing and uninstalling a service appears to be working correctly.
Member
There was a problem hiding this comment.
The files could be named install_windows.go and run_windows.go.
| Handler: &handler{}, | ||
| Logger: logger, | ||
| }) | ||
| return trace.NewAggregate(closeLogger(), err) |
Member
There was a problem hiding this comment.
Nit but I feel like it'd be best to put err first as it's arguably more important.
Contributor
cthach
pushed a commit
that referenced
this pull request
Jan 29, 2026
* Extract reusable function for service installation * Move `install_service_windows.go` to `lib/windowsservice` * Reintroduce `vnet/install_service_windows.go` * Make service runner reusable * Add missing service description and returns on error * Log service name when installing/uninstalling * Rename files * Put `err` first
gzdunek
added a commit
that referenced
this pull request
Mar 27, 2026
* Extract reusable function for service installation * Move `install_service_windows.go` to `lib/windowsservice` * Reintroduce `vnet/install_service_windows.go` * Make service runner reusable * Add missing service description and returns on error * Log service name when installing/uninstalling * Rename files * Put `err` first (cherry picked from commit 845caf9)
gzdunek
added a commit
that referenced
this pull request
Mar 30, 2026
* Extract reusable function for service installation * Move `install_service_windows.go` to `lib/windowsservice` * Reintroduce `vnet/install_service_windows.go` * Make service runner reusable * Add missing service description and returns on error * Log service name when installing/uninstalling * Rename files * Put `err` first (cherry picked from commit 845caf9)
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #59295
RFD #62545
This PR extracts the installation and running of the VNet service to make it more reusable. It will be used in the upcoming privileged update service.