Skip to content

Remove workaround for TypeScript compiler running out of memory#63053

Merged
ravicious merged 1 commit intomasterfrom
r7s/tsc-oom
Jan 22, 2026
Merged

Remove workaround for TypeScript compiler running out of memory#63053
ravicious merged 1 commit intomasterfrom
r7s/tsc-oom

Conversation

@ravicious
Copy link
Copy Markdown
Member

@ravicious ravicious commented Jan 22, 2026

This was added originally in #21168 to address TS running out of memory when type-checking the project. It looks like with the current version of TypeScript it's no longer needed and it makes the type checking faster by 10 seconds on my machine. It seems it has no effect on CI. Here's a run with the env var and without the env var. Both take around one minute.

Merging this to just master for now. We don't keep TS version in sync across release branches and I don't have time to test if it behaves correctly on other TS versions as well.

@ravicious ravicious added the no-changelog Indicates that a PR does not require a changelog entry label Jan 22, 2026
@ravicious ravicious requested review from gzdunek and ryanclark and removed request for hugoShaka and okraport January 22, 2026 10:08
@ravicious ravicious enabled auto-merge January 22, 2026 10:10
@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from ryanclark January 22, 2026 10:20
@ravicious ravicious added this pull request to the merge queue Jan 22, 2026
Merged via the queue into master with commit b97fb3a Jan 22, 2026
46 checks passed
@ravicious ravicious deleted the r7s/tsc-oom branch January 22, 2026 10:36
flyinghermit added a commit that referenced this pull request Jan 23, 2026
github-merge-queue Bot pushed a commit that referenced this pull request Jan 23, 2026
@ravicious
Copy link
Copy Markdown
Member Author

ravicious commented Jan 23, 2026

Welp it looks like it's still needed because otherwise the CI runs out of memory when checking teleport.e (#63091).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants