Capture postgres extended protocol queries in audit log #6303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
added
backport-required
database-access
|
@awly @fspmarshall Would appreciate a review on this one guys, thanks. |
awly
reviewed
Apr 7, 2021
r0mant
force-pushed
the
roman/prep-stmt
branch
2 times, most recently
from
5b1233f to
c35a718
Compare
awly
approved these changes
Apr 12, 2021
fspmarshall
approved these changes
Apr 13, 2021
r0mant
added a commit
that referenced
this pull request
Apr 14, 2021
r0mant
added a commit
that referenced
this pull request
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances database access Postgres protocol integration to support logging of Postgres "extended query protocol" messages in the audit log.
Extended query protocol is a fancy name for parameterized prepared statements. Normal SQL queries are executed with a single wire message (
Query) while prepared statements are executed in 3 steps:Parsemessage to prepare the (optionally) parameterized query.Bindmessage to "prime" the prepared query for execution and bind it to parameters into a what Postgres calls "destination portal".Executemessage to execute the specified "portal" i.e. query bound to parameters.More information about Postgres extended query protocol: https://www.postgresql.org/docs/10/protocol-flow.html#PROTOCOL-FLOW-EXT-QUERY.
Many GUI clients use this extended protocol flow to run SQL statements and without this these statements are not captured in our audit log at all. With this update, the queries and their parameters are captured, for example:
Fixes #6051. Also needs backport as this is going to 6.2.