[v17] Fix memory leak in access list reminder notifications#62664
Merged
tigrato merged 4 commits intobranch/v17from Jan 8, 2026
Merged
[v17] Fix memory leak in access list reminder notifications#62664tigrato merged 4 commits intobranch/v17from
tigrato merged 4 commits intobranch/v17from
Conversation
* Fix memory leak in access list reminder notifications Fixes a memory leak caused by variable shadowing where `nextKey` was redeclared in the pagination loop instead of being assigned. This caused the loop to always pass an empty pagination token, fetching the same page repeatedly and never terminating for tenants with more than 1000 pending access list review notifications. The fix renames the loop variable to `notificationsPageKey` to avoid shadowing and properly updates it with the next page token. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * handle code review comments * handle review feedback --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
rosstimothy
previously requested changes
Jan 7, 2026
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
Same comment as on the branch/v18 backport about addressing
#62649 (comment).
This PR re-introduces access list read rate limiting removed in #62649. The PR had merge enabled and was merged without addressing the feedback. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
Contributor
Author
cherry picked from #62670 |
espadolini
approved these changes
Jan 7, 2026
zmb3
approved these changes
Jan 7, 2026
Collaborator
zmb3
left a comment
zmb3
left a comment
There was a problem hiding this comment.
(Assuming the compilation error is fixed)
public-teleport-github-review-bot
bot
removed the request for review
from kopiczko
tigrato
force-pushed
the
bot/backport-62649-branch/v17
branch
from
3d59714 to
46dced8
Compare
fheinecke
added a commit
that referenced
this pull request
Jan 8, 2026
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
* Release 17.7.13 * Update changelog for #62664
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #62649 to branch/v17
changelog: Fixed a memory leak in access list reminder notifications affecting clusters with more than 1000 pending Access List reviews.