Unify device verification logic under lib/devicetrust/authz#62523
Merged
codingllama merged 4 commits intomasterfrom Dec 30, 2025
Merged
Unify device verification logic under lib/devicetrust/authz#62523codingllama merged 4 commits intomasterfrom
codingllama merged 4 commits intomasterfrom
Conversation
codingllama
added
the
no-changelog
Contributor
Author
|
@zmb3 @21KennethTran, I noticed the dupe logic while reviewing #62019, so here it is. Feel free to review it. |
zmb3
approved these changes
Dec 29, 2025
bl-nero
approved these changes
Dec 30, 2025
public-teleport-github-review-bot
bot
removed the request for review
from r0mant
Contributor
Author
|
Thanks for the quick review! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
21KennethTran
pushed a commit
that referenced
this pull request
Jan 6, 2026
* Unify device verification logic under lib/devicetrust/authz * Refactor verifyDeviceExtensions, nits * Disallow unknown modes * Reword comment
codingllama
added a commit
that referenced
this pull request
Jan 26, 2026
* Unify device verification logic under lib/devicetrust/authz * Refactor verifyDeviceExtensions, nits * Disallow unknown modes * Reword comment
codingllama
added a commit
that referenced
this pull request
Jan 29, 2026
* Unify device verification logic under lib/devicetrust/authz * Refactor verifyDeviceExtensions, nits * Disallow unknown modes * Reword comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unifies duplicate device authz logic under lib/services/role.go by reusing a newly-exposed function under lib/devicetrust/authz.
This is a noop in terms of behavior, but an improvement in terms of maintenance.