Skip to content

Add vnet config audit events#62383

Merged
tangyatsu merged 1 commit intomasterfrom
tangyatsu/add-vnet-config-audit-events
Jan 3, 2026
Merged

Add vnet config audit events#62383
tangyatsu merged 1 commit intomasterfrom
tangyatsu/add-vnet-config-audit-events

Conversation

@tangyatsu
Copy link
Copy Markdown
Contributor

@tangyatsu tangyatsu commented Dec 18, 2025

What

This PR adds missing audit logs for vnet_config Create/Update/Delete events so they are emitted during those operations and accessible in the UI

changelog: Added VNet config Create/Update/Delete audit events

Manual Tests

The following tests were performed:

  • tctl create -f test/vnet/vnet-config.yaml emits the VNet config create audit log
  • tctl edit vnet_configt emits the VNet config update audit log
  • tctl rm vnet_config/vnet-config isn’t explicitly supported in the CLI, I used a custom tctl build that adds VNet delete support, with that build this command emits the delete audit log.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 18, 2025

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
tangyatsu/add-vnet-config-audit-events 5f451ec 10 ✅SUCCEED tangyatsu-add-vnet-config-audit-events 2026-01-03 00:47:06

@tangyatsu tangyatsu requested a review from nklaassen December 22, 2025 19:30
@tangyatsu tangyatsu force-pushed the tangyatsu/add-vnet-config-audit-events branch from b2d639b to 5d0dc0d Compare December 22, 2025 20:42
Code: libevents.VnetConfigCreateCode,
Type: libevents.VnetConfigCreateEvent,
},
UserMetadata: authz.ClientUserMetadata(ctx),
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you seeing the same for other config resources like cluster_networking_config or session_recording_config?

@tangyatsu tangyatsu requested a review from zmb3 December 23, 2025 20:12
@tangyatsu tangyatsu force-pushed the tangyatsu/add-vnet-config-audit-events branch from a96bde1 to 191586d Compare December 23, 2025 22:56
@tangyatsu tangyatsu force-pushed the tangyatsu/add-vnet-config-audit-events branch from 69feb43 to 5f451ec Compare January 3, 2026 00:41
@tangyatsu tangyatsu enabled auto-merge January 3, 2026 01:00
@tangyatsu tangyatsu added this pull request to the merge queue Jan 3, 2026
Merged via the queue into master with commit 62e1efb Jan 3, 2026
47 checks passed
@tangyatsu tangyatsu deleted the tangyatsu/add-vnet-config-audit-events branch January 3, 2026 01:22
@backport-bot-workflows
Copy link
Copy Markdown
Contributor

@tangyatsu See the table below for backport results.

Branch Result
branch/v18 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants