[terraform] Fix kubernetes_resources defaults#62320
Merged
bernardjkim merged 9 commits intomasterfrom Dec 18, 2025
Merged
Conversation
hugoShaka
approved these changes
Dec 17, 2025
marcoandredinis
approved these changes
Dec 18, 2025
Contributor
|
@bernardjkim See the table below for backport results.
|
bernardjkim
added a commit
that referenced
this pull request
Dec 19, 2025
* [terraform] add v8 support to role resource * Remove V8_SUPPORT_CHANGES.md & update docs * Update kube_resources tests * Update tests to use v8 roles * Implement plan_modifier for kubernetes_resources * make gen-tfschema * Re-enable TestRoleVersionUpgrade test * Revert computed_fields --------- Co-authored-by: James Goodhouse <4684194+jamesgoodhouse@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 5, 2026
* [terraform] add v8 support to role resource * Remove V8_SUPPORT_CHANGES.md & update docs * Update kube_resources tests * Update tests to use v8 roles * Implement plan_modifier for kubernetes_resources * make gen-tfschema * Re-enable TestRoleVersionUpgrade test * Revert computed_fields --------- Co-authored-by: James Goodhouse <4684194+jamesgoodhouse@users.noreply.github.com>
21KennethTran
pushed a commit
that referenced
this pull request
Jan 6, 2026
* [terraform] add v8 support to role resource * Remove V8_SUPPORT_CHANGES.md & update docs * Update kube_resources tests * Update tests to use v8 roles * Implement plan_modifier for kubernetes_resources * make gen-tfschema * Re-enable TestRoleVersionUpgrade test * Revert computed_fields --------- Co-authored-by: James Goodhouse <4684194+jamesgoodhouse@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a plan_modifier for
role.spec.allow.kubernetes_resourcesto handle default value changes across role versions.Without this modifier, users have had trouble upgrading between role versions using the Terraform provider. The new plan modifier ensures that defaults for
kubernetes_resourcesare recomputed during version upgrades.For example, v7 roles provide the following default values for
kubernetes_resources:The v8 role now requires
api_groupand uses the following default:Without this new plan modifier, users will not be able to upgrade from v7 to v8 without manually specifying the
kubernetes_resources.api_groupwithin the Terraform config. This change should also fix previous issues with even older role versions.Changelog: Added a plan modifier to recompute kubernetes_resources defaults during role version upgrades, fixing Terraform role upgrade issues.