[v18] Remove 'wasm-pack' Build Dependency#62174
Merged
rhammonds-teleport merged 1 commit intobranch/v18from Dec 11, 2025
Merged
[v18] Remove 'wasm-pack' Build Dependency#62174rhammonds-teleport merged 1 commit intobranch/v18from
rhammonds-teleport merged 1 commit intobranch/v18from
Conversation
* Get a Teleport build working without wasm-pack * * seed docker images with wasm-opt, and wasm-bindgen-cli * Replace potentially confusing 'CARGO_TARGET_wasm' variable. * Replace oneoff .gitignore with a corresponding entry in the top level .gitignore. * Replace 'printf' used to create package.json file with a cleaner multiline string. * Remove unnecessary 'NEED_VERSION' * Use awk to find wasm-bindgen version without using 'cargo' since it doesn't seem to be available on ARM64 runners * Move 'WASM_BINDGEN_VERSION' definition out of versions.mk * Pass '--locked' flag to wasm-opt install
rhammonds-teleport
added
the
no-changelog
rhammonds-teleport
requested review from
camscale,
doggydogworld,
fheinecke,
klizhentas,
r0mant,
rosstimothy,
russjones and
zmb3
as code owners
zmb3
approved these changes
Dec 11, 2025
fheinecke
approved these changes
Dec 11, 2025
Contributor
fheinecke
left a comment
fheinecke
left a comment
There was a problem hiding this comment.
Please cut a dev build prior to merge to ensure that there is no branch-specific logic that breaks because of this
public-teleport-github-review-bot
bot
removed the request for review
from bl-nero
Contributor
Author
Of course! https://github.com/gravitational/teleport.e/actions/runs/20143189013/job/57817214307 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #58618 to branchv/18