Improve error wrapping in tbot identity service#62103
Merged
strideynet merged 1 commit intomasterfrom Dec 10, 2025
Merged
Conversation
rosstimothy
approved these changes
Dec 9, 2025
timothyb89
approved these changes
Dec 9, 2025
Contributor
|
@strideynet See the table below for backport results.
|
This was referenced Dec 10, 2025
21KennethTran
pushed a commit
that referenced
this pull request
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@webvictim ran into a fairly non-descript error recently:
The root cause being that the
known_hostsfile was owned by another user. I took a look and it turns out that in some of these older code paths, we've really not done a good job of wrapping errors.After my changes, it looks a little more like:
changelog: Improved detail of error messages for
identityservice intbot