Skip to content

Add fix for AltGr key#62101

Merged
danielashare merged 1 commit intomasterfrom
danielashare/altgr-fix
Dec 12, 2025
Merged

Add fix for AltGr key#62101
danielashare merged 1 commit intomasterfrom
danielashare/altgr-fix

Conversation

@danielashare
Copy link
Copy Markdown
Contributor

@danielashare danielashare commented Dec 9, 2025

We had a few customer reports that the AltGr + Q combination to print @ wasn't working.
The issue stems from browsers logically pressing LeftControl and RightAlt, when a user physically presses AltGr, and those keys not being picked up by getModifierState() because they're not physically being pressed. The fix is to skip synchronising Control and Alt if AltGr is pressed.

Closes #59883

changelog: Fixed issue where AltGr key combinations did not work correctly in remote desktop sessions.

Copy link
Copy Markdown
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but can we verify that the sticky keys fix is still good and add some test coverage?

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from ryanclark December 11, 2025 13:33
@danielashare danielashare force-pushed the danielashare/altgr-fix branch from 16647b7 to 2dc52a8 Compare December 12, 2025 10:21
@danielashare danielashare force-pushed the danielashare/altgr-fix branch 2 times, most recently from b35621e to 1d59db5 Compare December 12, 2025 13:00
@danielashare danielashare force-pushed the danielashare/altgr-fix branch from 1d59db5 to 0c80f88 Compare December 12, 2025 14:09
@danielashare danielashare added this pull request to the merge queue Dec 12, 2025
Merged via the queue into master with commit a72b4d4 Dec 12, 2025
42 checks passed
@danielashare danielashare deleted the danielashare/altgr-fix branch December 12, 2025 14:32
@backport-bot-workflows
Copy link
Copy Markdown
Contributor

@danielashare See the table below for backport results.

Branch Result
branch/v17 Create PR
branch/v18 Create PR

21KennethTran pushed a commit that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

French keyboard layout not working as expected on RDP sessions

3 participants