Fix event handler to gracefully drop malformed sessions#62073
Merged
Conversation
bernardjkim
approved these changes
Dec 9, 2025
zmb3
reviewed
Dec 9, 2025
hugoShaka
approved these changes
Dec 10, 2025
public-teleport-github-review-bot
bot
removed the request for review
from tigrato
Contributor
This was referenced Dec 10, 2025
21KennethTran
pushed a commit
that referenced
this pull request
Jan 6, 2026
* Update event handler to gracefully drop malformed sessions * Fix lint * Set IterateMissingRecordings in-flight sessions to double the concurrency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60317
Instead of panicking when ingesting malformed session events, the event handler now logs the errors and gracefully drops them. This change refactors
SpawnCriticalJobto eliminate the panic by aligning behavior withIterateMissingRecordings.In addition, for ingesting missing session recordings, the max in-flight sessions is now controlled by a value of double the
concurrency, instead of a fixed 10. This ensures regular ingestion and missing recordings ingestion is synced to one field.changelog: Fixed bug where event handler dies on malformed session events
changelog: Updated event handler to ingest missing session recordings at twice the
concurrencyinstead of only 10 sessions at a time