[v18] Reduce allocations in app server watcher#62014
Merged
rosstimothy merged 1 commit intobranch/v18from Dec 5, 2025
Merged
Conversation
The slice of resources receivied from the watcher contains a copy of all the items known by the watcher. The app server then cloned each app via types.Application.Copy to get a handle to a types.AppV3 so that the public address could be set if it was empty. The cloned apps are then added to a _new_ slice which is provided to the reconciler. To reduce memory consumption, types.Application.SetPublicAddr was added to make it possible to set the address without copying an app. The slice from the resource watcher is now reused instead of allocating a new slice for the amended applications.
zmb3
approved these changes
Dec 4, 2025
tigrato
approved these changes
Dec 4, 2025
public-teleport-github-review-bot
bot
removed the request for review
from nicholasmarais1158
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #61985 to branch/v18
changelog: Reduced memory consumption of the Application service.