Skip to content

Generate a reference for discovery_config#61992

Merged
ptgott merged 1 commit intomasterfrom
paul.gottschling/61931-discovery-config
Dec 10, 2025
Merged

Generate a reference for discovery_config#61992
ptgott merged 1 commit intomasterfrom
paul.gottschling/61931-discovery-config

Conversation

@ptgott
Copy link
Copy Markdown
Contributor

@ptgott ptgott commented Dec 4, 2025

See #61931

Edit the resource reference generator config to support the discovery_config resource and generate a reference guide to the resource's fields.

Also perform some minor cleanup of the resource reference generator config file.

Note that, in order to add the Metadata field to the reference, this change fixes a bug in which it only adds reference entries based on the fields of a given declaration, not the fields included in any embedded struct fields of the declaration. As part off this work, clarify function names, renaming handleEmbeddedStructFields to allFieldsForDecl and getRawTypes to typeForDecl.

Also remove a list of possible function declarations that the generator used in an earlier iteration but no longer uses.

@ptgott ptgott force-pushed the paul.gottschling/61931-discovery-config branch from 1d1f207 to 4d49852 Compare December 4, 2025 13:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 4, 2025

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
paul.gottschling/61931-discovery-config d70f984 3 ✅SUCCEED paul-gottschling-61931-discovery-config 2025-12-08 14:06:54

|exclude|A list of AWS Organizational Unit IDs to exclude. Only exact matches or wildcard (*) are supported. If empty, no Organizational Units are excluded by default.|[]string|
|include|A list of AWS Organizational Unit IDs to match. Only exact matches or wildcard (*) are supported. If empty, all Organizational Units are included by default.|[]string|

## AWSSSM
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging #61978 will allow us to fix this heading.

@ptgott ptgott force-pushed the paul.gottschling/61931-discovery-config branch from 4d49852 to f3f29a2 Compare December 4, 2025 16:30
@ptgott ptgott marked this pull request as ready for review December 4, 2025 16:51
@ptgott ptgott added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v18 labels Dec 4, 2025
See #61931

Edit the resource reference generator config to support the
`discovery_config` resource and generate a reference guide to the
resource's fields.

Also perform some minor cleanup of the resource reference generator
config file.

Note that, in order to add the `Metadata` field to the reference, this
change fixes a bug in which it only adds reference entries based on the
fields of a given declaration, not the fields included in any embedded
struct fields of the declaration. As part off this work, clarify
function names, renaming `handleEmbeddedStructFields` to
`allFieldsForDecl` and `getRawTypes` to `typeForDecl`.

Also remove a list of possible function declarations that the generator
used in an earlier iteration but no longer uses.
@ptgott ptgott force-pushed the paul.gottschling/61931-discovery-config branch from f3f29a2 to d70f984 Compare December 8, 2025 14:01
@ptgott ptgott added this pull request to the merge queue Dec 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2025
@ptgott ptgott added this pull request to the merge queue Dec 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2025
@ptgott ptgott added this pull request to the merge queue Dec 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2025
@ptgott ptgott added this pull request to the merge queue Dec 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2025
@ptgott ptgott added this pull request to the merge queue Dec 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2025
@ptgott ptgott added this pull request to the merge queue Dec 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2025
@ptgott ptgott added this pull request to the merge queue Dec 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2025
@ptgott ptgott added this pull request to the merge queue Dec 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 9, 2025
@ptgott ptgott added this pull request to the merge queue Dec 10, 2025
Merged via the queue into master with commit 829caa6 Dec 10, 2025
45 checks passed
@ptgott ptgott deleted the paul.gottschling/61931-discovery-config branch December 10, 2025 14:15
@backport-bot-workflows
Copy link
Copy Markdown
Contributor

@ptgott See the table below for backport results.

Branch Result
branch/v18 Create PR

21KennethTran pushed a commit that referenced this pull request Jan 6, 2026
See #61931

Edit the resource reference generator config to support the
`discovery_config` resource and generate a reference guide to the
resource's fields.

Also perform some minor cleanup of the resource reference generator
config file.

Note that, in order to add the `Metadata` field to the reference, this
change fixes a bug in which it only adds reference entries based on the
fields of a given declaration, not the fields included in any embedded
struct fields of the declaration. As part off this work, clarify
function names, renaming `handleEmbeddedStructFields` to
`allFieldsForDecl` and `getRawTypes` to `typeForDecl`.

Also remove a list of possible function declarations that the generator
used in an earlier iteration but no longer uses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/branch/v18 documentation no-changelog Indicates that a PR does not require a changelog entry size/md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants