Conversation
hugoShaka
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
github-actions
bot
requested review from
marcoandredinis,
mmcallister,
ptgott and
r0mant
Contributor
|
Amplify deployment status
|
hugoShaka
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
hugoShaka
requested review from
webvictim
and removed request for
mmcallister and
ptgott
zmb3
approved these changes
Nov 29, 2025
espadolini
approved these changes
Dec 1, 2025
public-teleport-github-review-bot
bot
removed request for
marcoandredinis,
r0mant,
tigrato and
webvictim
webvictim
approved these changes
Dec 1, 2025
| {{- end -}} | ||
|
|
||
| {{/* This renders the GOMEMLIMIT env var unless the user already specified it | ||
| in exrtaEnv, goMemLimitRatio is set to 0, or requests.memory.limit is unset. */}} |
Contributor
There was a problem hiding this comment.
Suggested change
| in exrtaEnv, goMemLimitRatio is set to 0, or requests.memory.limit is unset. */}} | |
| in extraEnv, goMemLimitRatio is set to 0, or requests.memory.limit is unset. */}} |
hugoShaka
force-pushed
the
hugo/set-gomemlimit
branch
from
4759023 to
d975044
Compare
hugoShaka
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
Contributor
|
@hugoShaka See the table below for backport results.
|
hugoShaka
added a commit
that referenced
this pull request
Dec 4, 2025
21KennethTran
pushed a commit
that referenced
this pull request
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets
GOMEMLIMITto 90% of the memory limit in theteleport-cluster,teleport-kube-agent, andteleport-relaycharts.Setting this environment variable reduces the probability of an OOM kill in case of spike/ high memory allocation rate. This was required when troubleshooting #61839
We are already doing this in Teleport Cloud, with values between 98% and 90% depending on the tenant size/activity. With this change I opted for the most conservative default.
This should not be a breaking change as I took extra care to not override potential existing GOMEMLIMIT vars set thorugh
extraEnvso I'll backport this as a bugfix to both v17 and v18.Changelog: Tuned
teleport-cluster,teleport-kube-agent, andteleport-relayHelm charts to reduce the probability of Teleport exceeding its memory limits and being OOM-Killed.GOMEMLIMITdefaults to 90% of the configured memory limits.