[v18] Fix kube discovery service poll_interval value not set correctly#61791
Merged
kshi36 merged 5 commits intobranch/v18from Dec 1, 2025
Merged
[v18] Fix kube discovery service poll_interval value not set correctly#61791kshi36 merged 5 commits intobranch/v18from
poll_interval value not set correctly#61791kshi36 merged 5 commits intobranch/v18from
Conversation
…60982) * Fix kube discovery service poll interval * Add unit test, pass down clocks in discovery configs * Leverage synctest, pass down clocks properly * Refactor
kshi36
changed the title
poll_interval value not set correctly
Contributor
Author
|
I omitted test changes in |
github-actions
bot
requested review from
bernardjkim,
r0mant and
rosstimothy
Contributor
Lets use testutils.synctest so that we can backport test coverage. |
r0mant
approved these changes
Nov 26, 2025
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
lgtm once Tim's comment is addressed
…evin/backport-60982-branch/v18
rosstimothy
approved these changes
Dec 1, 2025
public-teleport-github-review-bot
bot
removed the request for review
from bernardjkim
Contributor
Author
|
@rosstimothy Will need exclude flake, same for v17 backport #61792 |
Contributor
It's only a required check on master 🙃. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #60982 to branch/v18
changelog: Fixed bug where Kubernetes App Discovery
poll_intervalis not set correctly