Add paginated ListAuthServers/ListProxies#61702
Merged
Conversation
kiosion
added
do-not-merge
no-changelog
kiosion
force-pushed
the
maxim/add-authservers-proxies-list-fns
branch
from
e7a6931 to
2c69755
Compare
kiosion
force-pushed
the
maxim/add-authservers-proxies-list-fns
branch
from
2c69755 to
5668486
Compare
kiosion
force-pushed
the
maxim/add-authservers-proxies-list-fns
branch
2 times, most recently
from
1ec8c1d to
9f97bc2
Compare
espadolini
reviewed
Nov 26, 2025
rosstimothy
reviewed
Nov 26, 2025
kiosion
force-pushed
the
maxim/add-authservers-proxies-list-fns
branch
5 times, most recently
from
e3bad8f to
b00e1fc
Compare
espadolini
reviewed
Nov 28, 2025
kiosion
force-pushed
the
maxim/add-authservers-proxies-list-fns
branch
from
b00e1fc to
a3ecc1a
Compare
rosstimothy
reviewed
Dec 2, 2025
Comment on lines
+103
to
105
| // | ||
| // Deprecated: Prefer paginated variant [ListProxies]. | ||
| GetProxies() ([]types.Server, error) |
Contributor
There was a problem hiding this comment.
Can we remove this from the interface? It doesn't look like we call it anymore.
Contributor
Author
There was a problem hiding this comment.
it's used in fetchProxyPublicAddr as the fallback
Comment on lines
34
to
37
| // GetProxies returns a list of registered proxies. | ||
| // | ||
| // Deprecated: Prefer paginated variant [ListProxies]. | ||
| GetProxies() ([]types.Server, error) |
Contributor
There was a problem hiding this comment.
Can we remove this? It doesn't looked used anymore.
Comment on lines
198
to
199
| // Deprecated: Prefer paginated variant [ListProxies]. | ||
| GetProxies() ([]types.Server, error) |
Contributor
There was a problem hiding this comment.
Can we remove this if it is no longer used?
kiosion
force-pushed
the
maxim/add-authservers-proxies-list-fns
branch
2 times, most recently
from
bd657e3 to
eab7173
Compare
espadolini
approved these changes
Dec 11, 2025
Contributor
espadolini
left a comment
espadolini
left a comment
There was a problem hiding this comment.
+1 for trying to delete the legacy methods from interfaces rather than marking them as deprecated as @rosstimothy mentioned
rosstimothy
reviewed
Dec 11, 2025
kiosion
force-pushed
the
maxim/add-authservers-proxies-list-fns
branch
from
170a905 to
f6651da
Compare
- Add `ListAuthServers` and `ListProxyServers` RPCs to PresenceService
- Implement new funcs - Mark `GetAuthServers`/`GetProxies` deprecated - Replace existing usages
kiosion
force-pushed
the
maxim/add-authservers-proxies-list-fns
branch
from
f6651da to
1e83e41
Compare
rosstimothy
approved these changes
Dec 12, 2025
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
Thanks for seeing this through @kiosion!
Contributor
21KennethTran
pushed a commit
that referenced
this pull request
Jan 6, 2026
* types: Add `ListAuthServers`/`ListProxyServers` to PresenceService - Add `ListAuthServers` and `ListProxyServers` RPCs to PresenceService * feat: Implement `ListAuthServers`/`ListProxyServers` - Implement new funcs - Mark `GetAuthServers`/`GetProxies` deprecated - Replace existing usages
44 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetAuthServers/GetProxiesRequired for https://github.com/gravitational/teleport.e/pull/7709