Skip to content

[v18] add --roles flag to tsh request search, that allows listing requestable roles#61699

Merged
tangyatsu merged 2 commits intobranch/v18from
tangyatsu/add-ability-to-list-requestable-roles-via-tsh-backport-v18
Nov 24, 2025
Merged

[v18] add --roles flag to tsh request search, that allows listing requestable roles#61699
tangyatsu merged 2 commits intobranch/v18from
tangyatsu/add-ability-to-list-requestable-roles-via-tsh-backport-v18

Conversation

@tangyatsu
Copy link
Copy Markdown
Contributor

Backport #61457 to branch/v18

changelog: Added --roles flag for tsh request search, allowing users to list all requestable roles. This flag is mutually exclusive with --kind

@tangyatsu tangyatsu added tsh tsh - Teleport's command line tool for logging into nodes running Teleport. backport size/md labels Nov 21, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 21, 2025

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
tangyatsu/add-ability-to-list-requestable-roles-via-tsh-backport-v18 bed4378 2 ✅SUCCEED tangyatsu-add-ability-to-list-requestable-roles-via-tsh-backport-v18 2025-11-24 14:27:01

reqSearch.Flag("kube-kind", fmt.Sprintf("Kubernetes resource kind name (plural) to search for. Required with --kind=%q Ex: pods, deployements, namespaces, etc.", types.KindKubernetesResource)).StringVar(&cf.kubeResourceKind)
reqSearch.Flag("kind", fmt.Sprintf("Resource kind to search for (%s). Mutually exclusive with --roles.", strings.Join(types.RequestableResourceKinds, ", "))).StringVar(&cf.ResourceKind)
reqSearch.Flag("roles", "List requestable roles instead of searching for resources. Mutually exclusive with --kind.").BoolVar(&cf.RequestableRoles)
reqSearch.Flag("kube-kind", fmt.Sprintf("Kubernetes resource kind name (plural) to search for. Required with --kind=%q Ex: pods, deployments, namespaces, etc.", types.KindKubernetesResource)).StringVar(&cf.kubeResourceKind)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only difference from the original PR is that it also fixes a typo "deployements" in the help text

@tangyatsu tangyatsu marked this pull request as ready for review November 21, 2025 23:57
@tangyatsu tangyatsu requested a review from zmb3 November 21, 2025 23:58
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from avatus November 22, 2025 00:05
Copy link
Copy Markdown
Contributor

@cthach cthach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tangyatsu tangyatsu added this pull request to the merge queue Nov 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 24, 2025
@tangyatsu tangyatsu added this pull request to the merge queue Nov 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 24, 2025
@tangyatsu tangyatsu added this pull request to the merge queue Nov 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 24, 2025
@tangyatsu tangyatsu added this pull request to the merge queue Nov 24, 2025
Merged via the queue into branch/v18 with commit 9cd857d Nov 24, 2025
42 checks passed
@tangyatsu tangyatsu deleted the tangyatsu/add-ability-to-list-requestable-roles-via-tsh-backport-v18 branch November 24, 2025 18:50
@aadc-dev aadc-dev mentioned this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport documentation size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants