[v18] add --roles flag to tsh request search, that allows listing requestable roles#61699
Merged
tangyatsu merged 2 commits intobranch/v18from Nov 24, 2025
Conversation
Contributor
|
Amplify deployment status
|
tangyatsu
commented
Nov 21, 2025
| reqSearch.Flag("kube-kind", fmt.Sprintf("Kubernetes resource kind name (plural) to search for. Required with --kind=%q Ex: pods, deployements, namespaces, etc.", types.KindKubernetesResource)).StringVar(&cf.kubeResourceKind) | ||
| reqSearch.Flag("kind", fmt.Sprintf("Resource kind to search for (%s). Mutually exclusive with --roles.", strings.Join(types.RequestableResourceKinds, ", "))).StringVar(&cf.ResourceKind) | ||
| reqSearch.Flag("roles", "List requestable roles instead of searching for resources. Mutually exclusive with --kind.").BoolVar(&cf.RequestableRoles) | ||
| reqSearch.Flag("kube-kind", fmt.Sprintf("Kubernetes resource kind name (plural) to search for. Required with --kind=%q Ex: pods, deployments, namespaces, etc.", types.KindKubernetesResource)).StringVar(&cf.kubeResourceKind) |
Contributor
Author
There was a problem hiding this comment.
The only difference from the original PR is that it also fixes a typo "deployements" in the help text
zmb3
approved these changes
Nov 22, 2025
rosstimothy
approved these changes
Nov 22, 2025
…ble-roles-via-tsh-backport-v18
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #61457 to branch/v18
changelog: Added --roles flag for tsh request search, allowing users to list all requestable roles. This flag is mutually exclusive with --kind