Prevent flakiness in TestKube/Join#61693
Merged
rosstimothy merged 1 commit intomasterfrom Nov 22, 2025
Merged
Conversation
The test was reliant on all the output of a session being replicated to all parties before a 5s timer closed the session. To make the test more resiliant it was rewritten such that it validates the expected output from one of the parties output, then exits the session, then when all parties have been closed, it examines the entire output of the other parties to validate their output. Fixes #55044
rosstimothy
added
no-changelog
rosstimothy
commented
Nov 21, 2025
| } | ||
| } | ||
|
|
||
| func waitForOutput(ctx context.Context, r ReaderWithDeadline, expected string) error { |
Contributor
Author
There was a problem hiding this comment.
This was taken from lib/web/apiserver_test.go with a slight modification.
kshi36
approved these changes
Nov 22, 2025
zmb3
approved these changes
Nov 22, 2025
public-teleport-github-review-bot
bot
removed the request for review
from ravicious
Contributor
|
@rosstimothy See the table below for backport results.
|
This was referenced Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was reliant on all the output of a session being replicated to all parties before a 5s timer closed the session. To make the test more resiliant it was rewritten such that it validates the expected output from one of the parties output, then exits the session, then when all parties have been closed, it examines the entire output of the other parties to validate their output.
Fixes #55044