[v17] Fix AWS Console (w/ integration) access when using IP Pinning#61655
Merged
marcoandredinis merged 2 commits intobranch/v17from Nov 21, 2025
Merged
[v17] Fix AWS Console (w/ integration) access when using IP Pinning#61655marcoandredinis merged 2 commits intobranch/v17from
marcoandredinis merged 2 commits intobranch/v17from
Conversation
When IP Pinning is enabled, the certificate's pinned IP and the IP presented by the client in the connection must be the same. For AWS Console access which uses an integration, we don't use an Application Service to proxy connections, the Proxy Service is used instead. In this situation, it uses a `net.Pipe` which sets both Local/Remote addrs to `pipe`. When validating whether that's the same IP as the one present in the certificate's pinned IP, it fails because that's the address of an intermediate connection. This PR fixes this by wrapping the connection with an overrided `RemoteAddr` method which returns the true client's IP extracted from the context.
Tener
approved these changes
Nov 21, 2025
boxofrad
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #61489 to branch/v17
changelog: Fixed AWS Console access when using AWS IAM Roles Anywhere or AWS OIDC integrations, when IP Pinning is enabled.