[v18] Don't populate the domain field when heartbeating non-AD desktops#61643
Merged
zmb3 merged 1 commit intobranch/v18from Nov 26, 2025
Merged
[v18] Don't populate the domain field when heartbeating non-AD desktops#61643zmb3 merged 1 commit intobranch/v18from
zmb3 merged 1 commit intobranch/v18from
Conversation
zmb3
added
the
no-changelog
Contributor
danielashare
left a comment
danielashare
left a comment
There was a problem hiding this comment.
Pipeline is looking a bit unhealthy, maybe rebasing will fix it?
The domain field doesn't cause any problems, since we ignore it when `ad: false`, but it's technically incorrect so we shouldn't be setting the field at all.
zmb3
force-pushed
the
zmb3/v18-backport-61490
branch
from
867233d to
9bbc2cf
Compare
Collaborator
Author
|
Looks like we're good to go now, just need approvals. |
probakowski
approved these changes
Nov 26, 2025
danielashare
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The domain field doesn't cause any problems, since we ignore it when
ad: false, but it's technically incorrect so we shouldn't be setting the field at all.Backports #61490