Prevent chdir race condition in hasAccessibleHomeDir#61634
Merged
espadolini merged 1 commit intomasterfrom Nov 21, 2025
Merged
Conversation
espadolini
added
no-changelog
zmb3
approved these changes
Nov 20, 2025
hugoShaka
approved these changes
Nov 21, 2025
public-teleport-github-review-bot
bot
removed request for
atburke and
eriktate
Contributor
|
@espadolini See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
srv.hasAccessibleHomeDircan end up being called, even concurrently, by virtue ofhomeDirSubsysand file transfer~expansion when logging in as the user running Teleport. This PR adds a lock around changing and reverting the current directory, and makes the revert operation use a file rather than assuming that it's possible to go back to the original directory by absolute path, which is a little safer; the implementation follows the implementation of(*testing.T).Chdir.In addition, this PR removes the change of directory to the self-discovered directory of the Teleport executable when executing Teleport for reexec purposes.