Skip to content

Revert [v18] Update Audit page to use server side search/pagination#61603

Merged
avatus merged 1 commit intobranch/v18from
avatus/revertaudit
Nov 20, 2025
Merged

Revert [v18] Update Audit page to use server side search/pagination#61603
avatus merged 1 commit intobranch/v18from
avatus/revertaudit

Conversation

@avatus
Copy link
Copy Markdown
Contributor

@avatus avatus commented Nov 20, 2025

#61014

This reverts commit 7cca4c8.
Search is broken on athena audit logs, reverting to fix

changelog: Fixed a bug that prevented searching audit log events in the web UI when using Athena audit storage.

@avatus avatus added the no-changelog Indicates that a PR does not require a changelog entry label Nov 20, 2025
@github-actions github-actions bot added audit-log Issues related to Teleports Audit Log backport size/sm ui labels Nov 20, 2025
@avatus avatus enabled auto-merge November 20, 2025 12:10
#61014

This reverts commit 7cca4c8.
Search is broken on athena audit logs, reverting to fix
@avatus avatus force-pushed the avatus/revertaudit branch from 20ac846 to 59046d9 Compare November 20, 2025 12:46
@avatus avatus requested a review from bl-nero November 20, 2025 12:49
Copy link
Copy Markdown
Contributor

@nicholasmarais1158 nicholasmarais1158 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is much smaller than the original, is something missing? .pb.go files maybe?

Do we know what the root cause of the search issue is? Can we fix forward?

@avatus
Copy link
Copy Markdown
Contributor Author

avatus commented Nov 20, 2025

its smaller because i left the proto changes out (we cant be removing fields from the proto changes). i dont know the root cause but ill have to set up an athena backend, or test via cloud and i want to revert to unblock upgrade rollouts

Copy link
Copy Markdown
Contributor

@nicholasmarais1158 nicholasmarais1158 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested search locally. Not setup to use Athena backend.

@Tener
Copy link
Copy Markdown
Contributor

Tener commented Nov 20, 2025

@avatus I think we should add changelog entry regarding bugfix

@avatus avatus added this pull request to the merge queue Nov 20, 2025
@avatus avatus removed the no-changelog Indicates that a PR does not require a changelog entry label Nov 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2025
@avatus avatus added this pull request to the merge queue Nov 20, 2025
Merged via the queue into branch/v18 with commit 9bf05eb Nov 20, 2025
45 checks passed
@avatus avatus deleted the avatus/revertaudit branch November 20, 2025 14:26
@doggydogworld doggydogworld mentioned this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audit-log Issues related to Teleports Audit Log backport size/sm ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants