Revert [v18] Update Audit page to use server side search/pagination#61603
Merged
avatus merged 1 commit intobranch/v18from Nov 20, 2025
Merged
Revert [v18] Update Audit page to use server side search/pagination#61603avatus merged 1 commit intobranch/v18from
avatus merged 1 commit intobranch/v18from
Conversation
20ac846 to
59046d9
Compare
Contributor
nicholasmarais1158
left a comment
There was a problem hiding this comment.
This change is much smaller than the original, is something missing? .pb.go files maybe?
Do we know what the root cause of the search issue is? Can we fix forward?
Contributor
Author
|
its smaller because i left the proto changes out (we cant be removing fields from the proto changes). i dont know the root cause but ill have to set up an athena backend, or test via cloud and i want to revert to unblock upgrade rollouts |
nicholasmarais1158
approved these changes
Nov 20, 2025
Contributor
nicholasmarais1158
left a comment
There was a problem hiding this comment.
Tested search locally. Not setup to use Athena backend.
Tener
approved these changes
Nov 20, 2025
Contributor
|
@avatus I think we should add changelog entry regarding bugfix |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#61014
This reverts commit 7cca4c8.
Search is broken on athena audit logs, reverting to fix
changelog: Fixed a bug that prevented searching audit log events in the web UI when using Athena audit storage.