Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom environment variables in PAM with SSO interpolation #6158

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Allow custom environment variables in PAM with SSO interpolation #6158

merged 1 commit into from
Mar 30, 2021

Conversation

xacrimon
Copy link
Contributor

Similar to #6087 which was delayed due to a pending discussion about dynamic configuration.

@xacrimon xacrimon added feature-request Used for new features in Teleport, improvements to current should be #enhancements PAM Label related to Pluggable Authentication Module (PAM) Submethod. backport-required labels Mar 25, 2021
@xacrimon xacrimon requested a review from russjones March 25, 2021 20:24
@xacrimon xacrimon self-assigned this Mar 25, 2021
@xacrimon xacrimon force-pushed the joel/pam-prop-fileconf branch from 513ebcf to 94cefd8 Compare March 25, 2021 20:27
@xacrimon xacrimon added this to the 6.1 milestone Mar 25, 2021
@xacrimon xacrimon enabled auto-merge (rebase) March 25, 2021 20:58
@xacrimon xacrimon force-pushed the joel/pam-prop-fileconf branch from ced921f to 50fda4c Compare March 25, 2021 21:30
russjones
russjones reviewed Mar 25, 2021
View reviewed changes
Copy link
Contributor

@russjones russjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xacrimon Needs test coverage.

docs/pages/features/ssh-pam.mdx Outdated Show resolved Hide resolved
lib/srv/reexec.go Outdated Show resolved Hide resolved
lib/srv/ctx.go Show resolved Hide resolved
@russjones
Copy link
Contributor

russjones commented Mar 26, 2021 •
edited
Loading

@xacrimon Forgot to tell you this before, to test this you can update the PAM modules we currently use in tests:

https://github.com/gravitational/teleport/tree/master/build.assets/pam
https://github.com/gravitational/teleport/blob/master/integration/integration_test.go#L3198-L3334

@xacrimon xacrimon force-pushed the joel/pam-prop-fileconf branch from 50fda4c to c6bc5db Compare March 26, 2021 08:47
@xacrimon
Copy link
Contributor Author

@russjones added test coverage

a-palchikov
a-palchikov approved these changes Mar 26, 2021
View reviewed changes
docs/pages/features/ssh-pam.mdx Outdated Show resolved Hide resolved
docs/pages/features/ssh-pam.mdx Outdated Show resolved Hide resolved
docs/pages/features/ssh-pam.mdx Outdated Show resolved Hide resolved
docs/testplan.md Outdated Show resolved Hide resolved
lib/config/fileconf.go Outdated Show resolved Hide resolved
lib/srv/ctx.go Outdated Show resolved Hide resolved
lib/srv/ctx.go Outdated Show resolved Hide resolved
lib/config/fileconf.go Outdated Show resolved Hide resolved
lib/pam/config.go Outdated Show resolved Hide resolved
lib/srv/ctx.go Outdated Show resolved Hide resolved
@xacrimon xacrimon requested a review from russjones March 26, 2021 17:42
russjones
russjones reviewed Mar 26, 2021
View reviewed changes
lib/srv/ctx.go Outdated Show resolved Hide resolved
@xacrimon xacrimon force-pushed the joel/pam-prop-fileconf branch from 951c69a to c5232fc Compare March 29, 2021 15:17
@xacrimon xacrimon requested a review from russjones March 29, 2021 15:17
@xacrimon xacrimon disabled auto-merge March 29, 2021 16:26
@xacrimon xacrimon force-pushed the joel/pam-prop-fileconf branch from 03395fb to 199bcbc Compare March 29, 2021 18:36
russjones
russjones approved these changes Mar 30, 2021
View reviewed changes
lib/srv/ctx.go Outdated Show resolved Hide resolved
@xacrimon xacrimon force-pushed the joel/pam-prop-fileconf branch from 199bcbc to f26dd13 Compare March 30, 2021 15:29
@xacrimon xacrimon force-pushed the joel/pam-prop-fileconf branch from f26dd13 to beb184f Compare March 30, 2021 15:31
@xacrimon xacrimon merged commit 3f9f334 into master Mar 30, 2021
@xacrimon xacrimon deleted the joel/pam-prop-fileconf branch March 30, 2021 16:23
@xacrimon xacrimon mentioned this pull request Mar 30, 2021
Merged
@xacrimon xacrimon mentioned this pull request Mar 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klizhentas klizhentas klizhentas approved these changes

@a-palchikov a-palchikov a-palchikov approved these changes

@russjones russjones russjones approved these changes

@r0mant r0mant Awaiting requested review from r0mant

Assignees

@xacrimon xacrimon

Labels
backport-required feature-request Used for new features in Teleport, improvements to current should be #enhancements PAM Label related to Pluggable Authentication Module (PAM) Submethod.
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@xacrimon @russjones @klizhentas @a-palchikov