Skip to content

Strip VCS build information from go builds#61502

Merged
hugoShaka merged 1 commit intomasterfrom
hugo/remove-vcs-info-from-build
Nov 19, 2025
Merged

Strip VCS build information from go builds#61502
hugoShaka merged 1 commit intomasterfrom
hugo/remove-vcs-info-from-build

Conversation

@hugoShaka
Copy link
Copy Markdown
Contributor

@hugoShaka hugoShaka commented Nov 18, 2025

Scanners such as trivy are misinterpreting the go pseudoversions describing which commit was used to build the project. See: aquasecurity/trivy#9446

This causes false positives and considerable toil for our support team as every user/customer is seeing that Teleport is affected by CVE-2022-36633 (it is not).

Trivy devs don't seem to want to fix this so we must strip VCS information from the go binary to stop the false positives.

This actually makes the binaries less traceable, but this is the only workaround to reduce the noise caused by those tools.

Changelog: Prevented Trivy from reporting false positives when scanning the Teleport binaries.

Scanners such as trivy are misinterpreting the go pseudoversions
describing which commit was used to build the project.
See: aquasecurity/trivy#9446

This causes false positives and considerable toil for our support team
as every user/customer is seeing trivy reporting that Teleport is
affected by CVE-2022-36633 (it is not).

Trivy doesn't seem to want to fix their tool so we must strip VCS
information from the go binary to stop the false positives.

This actually makes the binaries _less traceable_, but this is the only
workaround to reduce the noise caused by those tools.
@github-actions github-actions bot requested review from aadc-dev and zmb3 November 18, 2025 23:39
@hugoShaka
Copy link
Copy Markdown
Contributor Author

We considered other alternatives such as:

@hugoShaka hugoShaka added this pull request to the merge queue Nov 19, 2025
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from aadc-dev November 19, 2025 17:29
Merged via the queue into master with commit 3c4b355 Nov 19, 2025
49 of 50 checks passed
@hugoShaka hugoShaka deleted the hugo/remove-vcs-info-from-build branch November 19, 2025 17:52
@backport-bot-workflows
Copy link
Copy Markdown
Contributor

@hugoShaka See the table below for backport results.

Branch Result
branch/v17 Create PR
branch/v18 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants