OIDC auth support for Azure auto-discovery#61494
Merged
Conversation
Tener
force-pushed
the
tener/azure-oidc-discovery-auth
branch
2 times, most recently
from
1dfa3b7 to
8ab5b2a
Compare
Tener
force-pushed
the
tener/azure-oidc-discovery-auth
branch
from
8ab5b2a to
d609316
Compare
Tener
force-pushed
the
tener/azure-oidc-discovery-auth
branch
from
f279a22 to
a1e54b6
Compare
Tener
changed the title
github-actions
bot
added
database-access
Tener
commented
Nov 21, 2025
| azureFetchers, err := dbfetchers.MakeAzureFetchers(s.cfg.AzureClients, s.cfg.AzureMatchers, "" /* discovery config */) | ||
| azureFetchers, err := dbfetchers.MakeAzureFetchers(ctx, func(ctx context.Context, integration string) (cloud.AzureClients, error) { | ||
| if integration != "" { | ||
| return nil, trace.NotImplemented("db_service discovery does not support Azure OIDC authentication; use discovery_service instead.") |
Contributor
Author
There was a problem hiding this comment.
While db service accepts Azure matchers with integration field set, for consistency across different configuration layers, it is missing the required machinery to fetch integration credentials. We might want to change this in the future, but I don't think we need to right now.
greedy52
reviewed
Nov 24, 2025
gabrielcorado
approved these changes
Nov 24, 2025
Contributor
Author
Not yet, but I do have plans in that direction, even though technically the requirements in #60815 only demand VM discovery to work. |
Contributor
I don't mind to drop db and kube. but if we do so, we should make the service fail when integration is specified. or we spend a day or two to do some quick testing. i can help out too. |
greedy52
approved these changes
Nov 25, 2025
public-teleport-github-review-bot
bot
removed the request for review
from marcoandredinis
GavinFrazar
reviewed
Nov 25, 2025
…lyWithT for improved error reporting
Contributor
Author
|
@r0mant this PR needs |
Collaborator
|
/excludeflake * |
Contributor
Tener
added a commit
that referenced
this pull request
Nov 27, 2025
* feat: add support for Azure OIDC integration auth for discovery service * docs: improve documentation for getAzureClients function * feat: add integration field to Azure fetcher configurations * update expected test result * update another expected test result; update said test to use EventuallyWithT for improved error reporting * lint fix
Tener
changed the title
cthach
pushed a commit
that referenced
this pull request
Dec 1, 2025
* feat: add support for Azure OIDC integration auth for discovery service * docs: improve documentation for getAzureClients function * feat: add integration field to Azure fetcher configurations * update expected test result * update another expected test result; update said test to use EventuallyWithT for improved error reporting * lint fix
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 2, 2025
* OIDC auth support to Azure auto-discovery (#61494) * feat: add support for Azure OIDC integration auth for discovery service * docs: improve documentation for getAzureClients function * feat: add integration field to Azure fetcher configurations * update expected test result * update another expected test result; update said test to use EventuallyWithT for improved error reporting * lint fix * fix import order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WithAzureIntegrationCredentialsis the key addition in this PR, adding an option to authenticate using particular integration. This is leveraged in discovery service whenever Azure matcher has the integration field set. The rest is plumbing/tests/config.Closes #60815
changelog: Added support for authenticating Azure resource discovery using Azure OIDC integrations