[v18] Fix App public_addr allows setting a conflicting hostname with the proxy when using capital letters #61290
Merged
cthach merged 1 commit intobranch/v18from Nov 12, 2025
Conversation
…oxy when using capital letters (#61123) * fix: App public_addr allows setting a conflicting hostname with the proxy when using capital letters Signed-off-by: Chris Thach <chris.thach@goteleport.com> * Only normalize once. Remove app public_addr validate. Signed-off-by: Chris Thach <chris.thach@goteleport.com> * Fix grpc tests Signed-off-by: Chris Thach <chris.thach@goteleport.com> * Polish and optimize ValidateApp Signed-off-by: Chris Thach <chris.thach@goteleport.com> * Apply suggestions from code review Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Strip all trailing dots Signed-off-by: Chris Thach <chris.thach@goteleport.com> * NewAppV3 should never panic during fuzzing. Improve comments in fuzz test. Signed-off-by: Chris Thach <chris.thach@goteleport.com> * Clarify app spec validated in CheckAndSetDefaults Signed-off-by: Chris Thach <chris.thach@goteleport.com> --------- Signed-off-by: Chris Thach <chris.thach@goteleport.com> Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
cthach
added
security
tangyatsu
approved these changes
Nov 12, 2025
rob-picard-teleport
approved these changes
Nov 12, 2025
rosstimothy
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #61123 to branch/v18
Changelog: Improve conflict detection of application public address and Teleport cluster addresses.