Fix TestRevocationService_CRL flakes with testing/synctest#61277
Merged
Fix TestRevocationService_CRL flakes with testing/synctest#61277
TestRevocationService_CRL flakes with testing/synctest#61277Conversation
boxofrad
added
flaky tests
machine-id
no-changelog
strideynet
approved these changes
Nov 12, 2025
Contributor
zmb3
approved these changes
Nov 17, 2025
public-teleport-github-review-bot
bot
removed request for
atburke,
camscale and
kimlisa
tigrato
approved these changes
Nov 17, 2025
boxofrad
added a commit
that referenced
this pull request
Nov 21, 2025
Backport #61277 to branch/v18.
boxofrad
added a commit
that referenced
this pull request
Nov 25, 2025
Backport #61277 to branch/v18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #53541.
This test seems to only flake in very rare circumstances. I was only able to reproduce it by running for several hours in a Docker container with 2% CPU allocation. When it does fail, the stack trace suggests it has been blocked receiving from the events channel for several minutes, so it's very likely a strange race-condition which
synctestshould eliminate by allowing us to definitively know when all goroutines are "durably" blocked.I've extended the excellent
grpctestpackage @tigrato added with a method to create a unidirectional server stream.