Merged
Conversation
rosstimothy
force-pushed
the
tross/kube_goaway_body
branch
from
bf398a4 to
3a8e456
Compare
rosstimothy
added
the
no-changelog
smallinsky
approved these changes
Nov 12, 2025
Contributor
There was a problem hiding this comment.
LGTM once the https://github.com/gravitational/teleport/pull/61264/files#r2518381718 (changing the header after the rw.WriteHeader(http.StatusTooManyRequests) was called) will be addressed
smallinsky
reviewed
Nov 12, 2025
Contributor
Author
|
Friendly ping reviewers |
espadolini
approved these changes
Nov 14, 2025
Follow up to #61142 which sets the response body so that clients which only look at the reason and not the headers will behave appropriately.
rosstimothy
force-pushed
the
tross/kube_goaway_body
branch
from
8922336 to
9a90d92
Compare
rosstimothy
added a commit
that referenced
this pull request
Nov 17, 2025
Follow up to #61142 which sets the response body so that clients which only look at the reason and not the headers will behave appropriately.
This was referenced Nov 17, 2025
rosstimothy
added a commit
that referenced
this pull request
Nov 17, 2025
Follow up to #61142 which sets the response body so that clients which only look at the reason and not the headers will behave appropriately.
rosstimothy
added a commit
that referenced
this pull request
Nov 17, 2025
Follow up to #61142 which sets the response body so that clients which only look at the reason and not the headers will behave appropriately.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 17, 2025
* Kubernetes: Handle GOAWAY requests This is an attempt to address #57766. When a request is terminated because the upstream Kubernetes API Server GOAWAY chance is exceeded, clients are informed to retry by replying with a 429 status code and a Retry-After header. This deviates from the approaches taken in #57881 and #60695 to favor simplicity and avoid buffering request data in a teleport process. The downside to this approach is that it requires clients to properly handle retry requests. * Populate GOAWAY response body (#61264) Follow up to #61142 which sets the response body so that clients which only look at the reason and not the headers will behave appropriately.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 17, 2025
* Kubernetes: Handle GOAWAY requests This is an attempt to address #57766. When a request is terminated because the upstream Kubernetes API Server GOAWAY chance is exceeded, clients are informed to retry by replying with a 429 status code and a Retry-After header. This deviates from the approaches taken in #57881 and #60695 to favor simplicity and avoid buffering request data in a teleport process. The downside to this approach is that it requires clients to properly handle retry requests. * Populate GOAWAY response body (#61264) Follow up to #61142 which sets the response body so that clients which only look at the reason and not the headers will behave appropriately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #61142 which sets the response body so that clients which only look at the reason and not the headers will behave appropriately.