[v17] Fix session recording truncation#60965
Merged
Joerger merged 1 commit intobranch/v17from Nov 8, 2025
Merged
Conversation
* Cleanup empty uploads rather than completing them. * Add regression test. * Update lib/events/filesessions/filestream_test.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Remove test for uploading an empty reservation upload. * Cleanup after FS lock. * Revert "Cleanup after FS lock." This reverts commit 9177f92. --------- Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
github-actions
bot
added
audit-log
rosstimothy
approved these changes
Nov 7, 2025
zmb3
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #60891 to branch/v17
changelog: fix an issue which could lead to session recordings saved on disk being truncated.