[v18] support session metadata generation for encrypted sessions#60945
Merged
tigrato merged 1 commit intobranch/v18from Nov 3, 2025
Merged
[v18] support session metadata generation for encrypted sessions#60945tigrato merged 1 commit intobranch/v18from
tigrato merged 1 commit intobranch/v18from
Conversation
github-actions
bot
added
audit-log
github-actions
bot
requested review from
Joerger,
eriktate,
rosstimothy and
ryanclark
* support session metadata generation for encrypted sessions Encrypted sessions do not use the normal uploader flow as the agents encrypt the data themselves and push the encrypted blobs directly to auth server. This behavior caused the session metadata and summaries generation to be skipped. This PR hooks the session summarization and metadata generation into the encrypted sessions completer - it can be via gRPC call or the local AuditLog. Since the encrypted session recordings receives the payloads encrypted and parts might be sent to different auth servers in case one disconnects in the middle, we always stream the full parts to retrieve the `session.end` event. This can be further improved in the future. This PR also adds support for encrypted session metadata and thumbnails files so all data stored in the recordings backend will be encrypted and users can't download the file and inspect the svg data. Contributes to #60689 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * add unit tests for session completer * add unit tests for audit log session completer * move file decrypter to file * handle code review comments * add todo list * remove duplicate code * fix typo * rename --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
force-pushed
the
tigrato/supportsummariesmetadataencryptedv18
branch
from
1f3a527 to
1313027
Compare
ryanclark
approved these changes
Nov 3, 2025
Joerger
approved these changes
Nov 3, 2025
public-teleport-github-review-bot
bot
removed request for
eriktate and
rosstimothy
russjones
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #60838 to branch/v18
Changelog: Enabled summarization and metadata generation for encrypted session recordings, storing metadata and summaries in encrypted form.