Skip to content

Bump eslint-plugin-react-hooks from 6.0.0-rc.2 to 7.0.1 #60919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gzdunek merged 2 commits into from
Nov 7, 2025
Merged

Bump eslint-plugin-react-hooks from 6.0.0-rc.2 to 7.0.1 #60919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3279701
Bump eslint-plugin-react-hooks from 6.0.0-rc.2 to 7.0.1
dependabot[bot] Nov 3, 2025
ab4e49d
Remove unnecessary updates
ravicious Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 10 additions & 31 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion web/packages/build/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"eslint-plugin-jest": "^29.0.1",
"eslint-plugin-jest-dom": "^5.5.0",
"eslint-plugin-react": "^7.37.5",
"eslint-plugin-react-hooks": "6.0.0-rc.2",
"eslint-plugin-react-hooks": "7.0.1",
Copy link
Copy Markdown
Member

@ravicious ravicious Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preserve-manual-memoization is still noisy, so I'm not re-enabling it.

I check if it's noisy by turning it into a warning, restarting my LSP and then checking if it shows a big warning throughout this function:

teleport/web/packages/teleport/src/WorkloadIdentity/WorkloadIdentities.tsx

Lines 84 to 104 in eadc668

const handleFetchNext = useCallback(() => {
const search = new URLSearchParams(location.search);
search.set('page', data?.next_page_token ?? '');
history.replace(
{
pathname: location.pathname,
search: search.toString(),
},
{
prevPageTokens: [...prevPageTokens, pageToken],
}
);
}, [
data?.next_page_token,
history,
location.pathname,
location.search,
pageToken,
prevPageTokens,
]);

It seems that the problem is pageToken. React Compiler thinks it can be mutated later. I guess it's true but I don't see how it's different from other deps in this callback.

Someone made an issue about it: facebook/react#34924

"eslint-plugin-storybook": "^9.1.3",
"eslint-plugin-testing-library": "7.13.3",
"eslint-plugin-unused-imports": "^4.3.0",
Expand Down
Loading