[v18] Fix encrypted recording uploads in S3#60895
Merged
rosstimothy merged 1 commit intobranch/v18from Nov 3, 2025
Merged
Conversation
* Add necessary padding to encrypted recordings for s3. * Add padded part instead of editing existing part; Don't pad last upload part; Support skipping padded part in streamer. * Reconstruct encrypted uploads from agent. * Concatenate upload parts into a single upload part instead of restructuring and combining them. * Make iterator buffer safe. * Remove padding from 128kb parts during concatenation. * Fix padding through gRPC service. * Cleanup; Fix discarded padding logic. * Add tests. * Fix bad upload test. * Expand test, add comments. * Minor edits. * Add padding helper with test; Add comments. * Fix tests, lint. * Don't use TELEPORT_UNSTABLE_GRPC_RECV_SIZE. * Apply suggestions from code review Co-authored-by: Erik Tate <erik.tate@goteleport.com> --------- Co-authored-by: Erik Tate <erik.tate@goteleport.com>
github-actions
bot
added
audit-log
rosstimothy
approved these changes
Nov 1, 2025
eriktate
approved these changes
Nov 1, 2025
tigrato
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #60542 to branch/v18
Changelog: Fix a bug where encrypted sessions recordings could not be uploaded to S3.