Conversation
github-actions
bot
added
audit-log
eriktate
force-pushed
the
eriktate/fix-recording-24h-reset
branch
from
0612631 to
ff8bdd2
Compare
rosstimothy
approved these changes
Oct 31, 2025
tigrato
approved these changes
Oct 31, 2025
public-teleport-github-review-bot
bot
removed request for
gabrielcorado and
greedy52
Base automatically changed from
joerger/pad-encrypted-recordings-s3
to
master
October 31, 2025 22:03
eriktate
force-pushed
the
eriktate/fix-recording-24h-reset
branch
from
ff8bdd2 to
f281f6a
Compare
Contributor
eriktate
added a commit
that referenced
this pull request
Nov 3, 2025
mmcallister
pushed a commit
that referenced
this pull request
Nov 19, 2025
mmcallister
pushed a commit
that referenced
this pull request
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially addresses #60860. It reads the first part of an async upload to confirm whether or not it's encrypted before starting the encrypted upload flow. Without this check an upload will be created for an encrypted recording using the same session ID before we encounter the
skip encrypted upload error. The recording will then proceed to the plaintext upload flow which will create another upload that proceeds through the entire lifecycle.The upload created by the encrypted flow remains empty until the completer completes it and overwrites the original session data.
changelog: Fixed a bug causing unencrypted session recordings to be deleted 24 hours after being created while using
nodeandproxyrecording modes.