Add support for `role.spec.allow.request.reason.prompt` to specify custom reason prompts for Access Requests by kshi36 · Pull Request #60847 · gravitational/teleport

kshi36 · 2025-10-30T20:41:59Z

Added support for role.spec.allow.request.reason.prompt, which allows Access Requests to specify a custom reason prompt per role/resource

changelog: Added support for custom reason prompts for Access Requests, per requested role/resource (role.spec.allow.request.reason.prompt)

…custom reason prompts for requestable `roles`/`search_as_roles`

…pt displays

…/custom-access-request-prompt

github-actions · 2025-10-30T21:16:42Z

Amplify deployment status

Branch	Commit	Job ID	Status	Preview	Updated (UTC)
kevin/custom-access-request-prompt	`f4c549a`	7	✅SUCCEED	kevin-custom-access-request-prompt	2025-11-06 19:09:37

kopiczko

Looks good in general I'd just like a bit clearer documentation and let's please also update the test plan https://github.com/gravitational/teleport/blob/master/.github/ISSUE_TEMPLATE/testplan.md#igs

kshi36 · 2025-11-03T18:32:11Z

Looks good in general I'd just like a bit clearer documentation and let's please also update the test plan https://github.com/gravitational/teleport/blob/master/.github/ISSUE_TEMPLATE/testplan.md#igs

I noticed that there are test plan changes for Access Request that have not been merged yet, that involve the same logic:
#55247

Should I simply re-add it and build off it? I can do it in a separate PR for updating the test plan

kopiczko

This LGTM with the docs suggestions applied. I'm only waiting for the test plan update. I've already asked to merge the hanging PR for the test plan.

kshi36 · 2025-11-04T23:17:34Z

Test plan #61022

kopiczko

LGTM, thanks!

…/custom-access-request-prompt

backport-bot-workflows · 2025-11-06T21:24:34Z

@kshi36 See the table below for backport results.

Branch	Result
branch/v18	Failed

…stom reason prompts for Access Requests (#60847) * Added support for `role.spec.allow.request.reason.prompt` to specify custom reason prompts for requestable `roles`/`search_as_roles` * Update terraform schema & docs * Updated role-spec docs to include support for and updated UI for prompt displays * Fix lint * Update reference docs * Include prompt output for tctl, update reference docs, and fix UI * Update docs * Fix e ref

…stom reason prompts for Access Requests (#60847) (#61127) * Added support for `role.spec.allow.request.reason.prompt` to specify custom reason prompts for requestable `roles`/`search_as_roles` * Update terraform schema & docs * Updated role-spec docs to include support for and updated UI for prompt displays * Fix lint * Update reference docs * Include prompt output for tctl, update reference docs, and fix UI * Update docs * Fix e ref

kshi36 added 4 commits October 28, 2025 15:45

Added support for role.spec.allow.request.reason.prompt to specify …

24a9d3b

…custom reason prompts for requestable `roles`/`search_as_roles`

Update terraform schema & docs

f11209a

Updated role-spec docs to include support for and updated UI for prom…

8ffd2e2

…pt displays

Merge branch 'master' of github.com:gravitational/teleport into kevin…

56d26d4

…/custom-access-request-prompt

kshi36 temporarily deployed to docs-amplify October 30, 2025 21:16 — with GitHub Actions Inactive

Fix lint

0943f1e

kshi36 temporarily deployed to docs-amplify October 30, 2025 21:29 — with GitHub Actions Inactive

kshi36 added the backport/branch/v18 label Oct 30, 2025

kshi36 requested review from kopiczko, r0mant and smallinsky October 30, 2025 22:14

kshi36 marked this pull request as ready for review October 30, 2025 22:14

github-actions bot added documentation helm size/md ui labels Oct 30, 2025

github-actions bot requested review from alexhemard, avatus, bernardjkim, bl-nero, flyinghermit, gzdunek, hugoShaka, kimlisa, kiosion, marcoandredinis, mmcallister, nicholasmarais1158 and ptgott October 30, 2025 22:15

r0mant removed request for gzdunek, kimlisa, kiosion, ptgott and rudream October 30, 2025 22:48

bernardjkim reviewed Oct 31, 2025

View reviewed changes

Comment thread docs/pages/identity-governance/access-requests/access-request-configuration.mdx

Comment thread docs/pages/identity-governance/access-requests/access-request-configuration.mdx Outdated

Update reference docs

d68bccb

kshi36 temporarily deployed to docs-amplify October 31, 2025 21:33 — with GitHub Actions Inactive

kopiczko reviewed Nov 3, 2025

View reviewed changes

Comment thread docs/pages/identity-governance/access-requests/access-request-configuration.mdx Outdated

Comment thread lib/services/access_request.go Outdated

Include prompt output for tctl, update reference docs, and fix UI

0ecd7fa

kopiczko reviewed Nov 4, 2025

View reviewed changes

Update docs

05f9a01

bernardjkim approved these changes Nov 5, 2025

View reviewed changes

kopiczko approved these changes Nov 5, 2025

View reviewed changes

smallinsky approved these changes Nov 5, 2025

View reviewed changes

Merge branch 'master' of github.com:gravitational/teleport into kevin…

5fb7e5c

…/custom-access-request-prompt

kshi36 temporarily deployed to docs-amplify November 6, 2025 18:59 — with GitHub Actions Inactive

public-teleport-github-review-bot bot removed the request for review from r0mant November 6, 2025 18:59

Fix e ref

f4c549a

kshi36 temporarily deployed to docs-amplify November 6, 2025 19:07 — with GitHub Actions Inactive

kshi36 added this pull request to the merge queue Nov 6, 2025

Merged via the queue into master with commit 36bbc6c Nov 6, 2025
46 checks passed

kshi36 deleted the kevin/custom-access-request-prompt branch November 6, 2025 21:23

kshi36 mentioned this pull request Nov 6, 2025

[v18] Add support for role.spec.allow.request.reason.prompt to specify custom reason prompts for Access Requests #61127

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for `role.spec.allow.request.reason.prompt` to specify custom reason prompts for Access Requests#60847

Add support for `role.spec.allow.request.reason.prompt` to specify custom reason prompts for Access Requests#60847
kshi36 merged 10 commits intomasterfrom
kevin/custom-access-request-prompt

kshi36 commented Oct 30, 2025

Uh oh!

github-actions bot commented Oct 30, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

kopiczko left a comment

Uh oh!

Uh oh!

Uh oh!

kshi36 commented Nov 3, 2025 •

edited

Loading

Uh oh!

kopiczko left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kshi36 commented Nov 4, 2025

Uh oh!

kopiczko left a comment

Uh oh!

Uh oh!

backport-bot-workflows bot commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

kshi36 commented Oct 30, 2025

Uh oh!

github-actions bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kopiczko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kshi36 commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kopiczko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kshi36 commented Nov 4, 2025

Uh oh!

kopiczko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

backport-bot-workflows bot commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Oct 30, 2025 •

edited

Loading

kshi36 commented Nov 3, 2025 •

edited

Loading