Skip to content

[v18] Fix the recording player for legacy recordings #60832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bl-nero merged 1 commit into from
Oct 30, 2025
Merged

[v18] Fix the recording player for legacy recordings #60832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions web/packages/teleport/src/SessionRecordings/view/player/RecordingPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export interface RecordingPlayerProps<
TEndEventType extends TEventType = TEventType,
> {
duration: number;
onTimeChange: (time: number) => void;
onTimeChange?: (time: number) => void;
onToggleSidebar?: () => void;
onToggleTimeline?: () => void;
onToggleFullscreen?: () => void;
Expand Down Expand Up @@ -104,13 +104,13 @@ export function RecordingPlayer<
});

stream.on('time', time => {
if (!controlsRef.current || !eventInfoRef.current) {
return;
if (controlsRef.current) {
controlsRef.current.setTime(time);
}
onTimeChange?.(time);
if (eventInfoRef.current) {
eventInfoRef.current.setTime(time);
}

controlsRef.current.setTime(time);
onTimeChange(time);
eventInfoRef.current.setTime(time);
});

stream.loadInitial();
Expand Down Expand Up @@ -177,11 +177,13 @@ export function RecordingPlayer<
overflow="hidden"
position="relative"
>
<CurrentEventInfo
events={events}
onSeek={handleSeek}
ref={eventInfoRef}
/>
{events && (
<CurrentEventInfo
events={events}
onSeek={handleSeek}
ref={eventInfoRef}
/>
)}

{showPlayButton && (
<PlayButton onClick={handlePlay}>
Expand Down
Loading