Merged
Conversation
GavinFrazar
added
db/mongo
GavinFrazar
commented
Oct 28, 2025
Comment on lines
+78
to
+80
| if err := top.Disconnect(ctx); err != nil { | ||
| e.Log.WarnContext(e.Context, "Failed to close topology", "error", err) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is the line that actually fixes the leak.
We just needed to disconnect from topology monitoring on errors from server selection or auth handshake.
GavinFrazar
force-pushed
the
gavinfrazar/fix-mongodb-connection-leak
branch
2 times, most recently
from
9619944 to
33e70ea
Compare
github-actions
bot
added
database-access
greedy52
approved these changes
Oct 28, 2025
gabrielcorado
approved these changes
Oct 28, 2025
GavinFrazar
force-pushed
the
gavinfrazar/fix-mongodb-connection-leak
branch
from
33e70ea to
b026c2d
Compare
Contributor
|
FYI, v16 will be EOL by the end of this week. Does the customer have plan to upgrade to a newer version? |
This fixes a topology monitoring connection leak. The leak was triggered by an error during server selection or the initial auth handshake with the MongoDB server.
GavinFrazar
force-pushed
the
gavinfrazar/fix-mongodb-connection-leak
branch
from
b026c2d to
52c9111
Compare
Contributor
|
@GavinFrazar See the table below for backport results.
|
This was referenced Oct 28, 2025
mmcallister
pushed a commit
that referenced
this pull request
Nov 6, 2025
This fixes a topology monitoring connection leak. The leak was triggered by an error during server selection or the initial auth handshake with the MongoDB server.
mmcallister
pushed a commit
that referenced
this pull request
Nov 19, 2025
This fixes a topology monitoring connection leak. The leak was triggered by an error during server selection or the initial auth handshake with the MongoDB server.
mmcallister
pushed a commit
that referenced
this pull request
Nov 20, 2025
This fixes a topology monitoring connection leak. The leak was triggered by an error during server selection or the initial auth handshake with the MongoDB server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fixed MongoDB topology monitoring connection leak in the Teleport Database Service.
This fixes a topology monitoring connection leak.
The leak was triggered by an error during server selection or the initial auth handshake with the MongoDB server.
I decided to pull this out of the connection pool PR draft since the actual code change to fix the bug is only a few lines and has nothing to do with reducing user<->db agent connection amplification.