Terraform: Modernize teleport_bot resource#60623
Merged
Conversation
Contributor
|
Amplify deployment status
|
strideynet
reviewed
Oct 28, 2025
strideynet
approved these changes
Oct 28, 2025
Contributor
|
Does this need a label for v18 backport? |
marcoandredinis
approved these changes
Nov 5, 2025
hugoShaka
approved these changes
Nov 5, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #60310 which is far less disruptive to the user, but much more complex internally.
It evolves the
teleport_botresource such that:name,roles, andtraitsattributes are now deprecated, and have been replaced with RFD 153-stylemetadataandspecobjects to match our other resourcesteleport_botresourcesThe complexity stems from the fact that, because the Terraform provider's version is directly coupled to the auth server version, making backward-incompatible changes to resource schema is additionally disruptive. So we want to support both the old and new "schemas" at the same time, and allow the user to update their configuration when they're ready.
An alternative would be to increment the schema "version" and provide a
StateUpgrademethod, but this would still require the user to update their configuration before the next run.It is not permissible to mix and match old and new-style attributes, because this makes the mapping to/from protobuf more complex.
Closes #40654, #51555, #56910.
changelog: Terraform:
teleport_botresource now supports import, and follows the standard resource structure