[v18] feat: Bot instances advanced filter#60558
Closed
nicholasmarais1158 wants to merge 2 commits intonicholasmarais1158/backport-59263-branch/v18from
Closed
[v18] feat: Bot instances advanced filter#60558nicholasmarais1158 wants to merge 2 commits intonicholasmarais1158/backport-59263-branch/v18from
nicholasmarais1158 wants to merge 2 commits intonicholasmarais1158/backport-59263-branch/v18from
Conversation
* Add version and hostname indexes to cache
* Add `ListBotInstancesV2` rpc and use request options
* Add v2 bot instance list endpoint
* Use v2 endpoint in web UI
* Pass signal through to support aborting requests
* Fix comment typo
* Rename util func
* Add expression parser
* Contribute `to_string` function to default parser
* Add API support for `query` filter
* Fix `SearchPanel` submit with advanced toggle
* Add advanced search to web UI
* Deprecate `ListBotInstances` rpc
* Encode hostname in cache key
* Address pre-release sorting in version numbers
* Rename bot instance cache utils
* Fix lint deprecation warnings
* Extract filter fields to message
* Replace `fmt.Sprintf("%06d", ...)`
* Update invalid sort field error
* Fallback to v1 endpoint if possible
* Use `strcase` for case-insensitive compare
* Backend results are filtered by bot name so no need to re-filter in `MatchBotInstance`
* Use `t.Context()`
* Remove expression methods
* Remove unnecessary fallback comments
* Return early if only bot name filter is required (backend only)
* Fix lint
* replace `to_string` with `equals` (version type only)
* Fix comment
* Remove unnecessary `to_string` tests
* Switch to a true equals function
# Conflicts:
# lib/cache/bot_instance.go
# web/packages/teleport/src/BotInstances/List/BotInstancesList.tsx
nicholasmarais1158
added
machine-id
no-changelog
strideynet
approved these changes
Oct 28, 2025
Contributor
|
If these backports have to land at the same time (and they have to, this PR breaks "logical" compatibility in |
Contributor
Author
|
Superseded by #60761. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #59374 and #59819 to branch/v18
Updates: #57994