Adds scope to ServerV2 in SSH heartbeats#60524
Conversation
9a3b158 to
4b91604
Compare
|
Amplify deployment status
|
rosstimothy
left a comment
There was a problem hiding this comment.
@fspmarshall @espadolini should we add a scope field to all agent resources before this gets in a release - even if nodes will be the only resources that populate this field for the near future?
@rosstimothy @espadolini I added the |
espadolini
left a comment
There was a problem hiding this comment.
Can older auth versions running concurrently with scope-aware ones cause permanent problems, or will they only grant too many permissions while they are running?
| types.UpdaterV2Info UpdaterInfo = 8; | ||
|
|
||
| // The scope that the instance should heartbeat against. | ||
| string scope = 9; |
There was a problem hiding this comment.
Is the scope something that the agent needs to be aware of and tell the auth about (even if just for confirmation)?
a8130ee to
484df1a
Compare
bae72e3 to
b8f04d3
Compare
espadolini
left a comment
There was a problem hiding this comment.
I think you should also add a check for the scope in services.CompareServers.
b8f04d3 to
a5a6fb4
Compare
a5a6fb4 to
93e4c7b
Compare
This PR adds scope validation to heartbeats and configures SSH servers to populate a scope value using the
AgentScopefound in its identity. Other server types do not yet populate a scope, so their scope validation during heartbeats will just verify that there is no scope