[v17] feat: List bot instances version and hostname sort#60521
Closed
nicholasmarais1158 wants to merge 2 commits intobranch/v17from
Closed
[v17] feat: List bot instances version and hostname sort#60521nicholasmarais1158 wants to merge 2 commits intobranch/v17from
nicholasmarais1158 wants to merge 2 commits intobranch/v17from
Conversation
* Add version and hostname indexes to cache
* Add `ListBotInstancesV2` rpc and use request options
* Add v2 bot instance list endpoint
* Use v2 endpoint in web UI
* Pass signal through to support aborting requests
* Fix comment typo
* Rename util func
* Deprecate `ListBotInstances` rpc
* Encode hostname in cache key
* Address pre-release sorting in version numbers
* Rename bot instance cache utils
* Fix lint deprecation warnings
* Extract filter fields to message
* Replace `fmt.Sprintf("%06d", ...)`
* Update invalid sort field error
* Fallback to v1 endpoint if possible
* Use `strcase` for case-insensitive compare
* Backend results are filtered by bot name so no need to re-filter in `MatchBotInstance`
* Revert "Replace `fmt.Sprintf("%06d", ...)`"
This reverts commit 2fbd797.
# Conflicts:
# web/packages/teleport/src/BotInstances/BotInstances.tsx
nicholasmarais1158
added
machine-id
no-changelog
avatus
approved these changes
Oct 24, 2025
espadolini
approved these changes
Oct 24, 2025
espadolini
requested changes
Oct 28, 2025
Contributor
espadolini
left a comment
espadolini
left a comment
There was a problem hiding this comment.
As previously mentioned in #59374 (comment), this backport must include #60557 or there will be a compatibility break in ListBotInstancesV2.
Contributor
Author
|
Will backport all bot instance change together instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #59263 to branch/v17
Updates: #57994