Skip to content

Fix Discovery boot when Proxy is not yet available#60457

Merged
marcoandredinis merged 1 commit intomasterfrom
marco/discovery_fix-missing-public-addr
Oct 23, 2025
Merged

Fix Discovery boot when Proxy is not yet available#60457
marcoandredinis merged 1 commit intomasterfrom
marco/discovery_fix-missing-public-addr

Conversation

@marcoandredinis
Copy link
Copy Markdown
Contributor

@marcoandredinis marcoandredinis commented Oct 22, 2025

If teleport is started with just Auth and Discovery in the same process, the Public Proxy Addr is not available.

Even tho this means that Discovery will not be able to enroll Servers, this is a valid set up.

When the Proxy becomes available, the next Discovery iteration will correctly enroll servers.

Not adding a changelog because this didn't made into any release branch.

Thank you @smallinsky for reporting this early.

@marcoandredinis marcoandredinis added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v18 labels Oct 22, 2025
@marcoandredinis
Copy link
Copy Markdown
Contributor Author

@r0mant Can I please get another pass on the flaky tests detector?
This PR is removing the field that was added to the DiscoveryService config struct, which was added here: #60224

@r0mant
Copy link
Copy Markdown
Collaborator

r0mant commented Oct 22, 2025

/excludeflake *

@marcoandredinis marcoandredinis force-pushed the marco/discovery_fix-missing-public-addr branch from a51100d to dd19b57 Compare October 23, 2025 14:56
@marcoandredinis
Copy link
Copy Markdown
Contributor Author

@camscale @ryanclark Can you please take a look when you get a chance?
Thank you

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from camscale October 23, 2025 15:00
@marcoandredinis marcoandredinis added this pull request to the merge queue Oct 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2025
@marcoandredinis marcoandredinis added this pull request to the merge queue Oct 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2025
If teleport is started with just Auth and Discovery in the same host,
the Public Proxy Addr is not available.

Even tho this means that Discovery will not be able to enroll Servers,
this is a valid set up.

When the Proxy becomes available, the next Discovery iteration will
correctly enroll servers.
@marcoandredinis marcoandredinis force-pushed the marco/discovery_fix-missing-public-addr branch from dd19b57 to f4b2832 Compare October 23, 2025 16:48
@marcoandredinis marcoandredinis added this pull request to the merge queue Oct 23, 2025
Merged via the queue into master with commit 657596e Oct 23, 2025
41 checks passed
@marcoandredinis marcoandredinis deleted the marco/discovery_fix-missing-public-addr branch October 23, 2025 17:47
@backport-bot-workflows
Copy link
Copy Markdown
Contributor

@marcoandredinis See the table below for backport results.

Branch Result
branch/v18 Failed

marcoandredinis added a commit that referenced this pull request Oct 23, 2025
If teleport is started with just Auth and Discovery in the same host,
the Public Proxy Addr is not available.

Even tho this means that Discovery will not be able to enroll Servers,
this is a valid set up.

When the Proxy becomes available, the next Discovery iteration will
correctly enroll servers.
marcoandredinis added a commit that referenced this pull request Oct 24, 2025
If teleport is started with just Auth and Discovery in the same host,
the Public Proxy Addr is not available.

Even tho this means that Discovery will not be able to enroll Servers,
this is a valid set up.

When the Proxy becomes available, the next Discovery iteration will
correctly enroll servers.
marcoandredinis added a commit that referenced this pull request Oct 24, 2025
If teleport is started with just Auth and Discovery in the same host,
the Public Proxy Addr is not available.

Even tho this means that Discovery will not be able to enroll Servers,
this is a valid set up.

When the Proxy becomes available, the next Discovery iteration will
correctly enroll servers.
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2025
…ipt` SSM Document (#60434)

* Use AWS-RunShellScript as the default SSM Doc in EC2 Auto Discover

* escape url values

* Fix Discovery boot when Proxy is not yet available (#60457)

If teleport is started with just Auth and Discovery in the same host,
the Public Proxy Addr is not available.

Even tho this means that Discovery will not be able to enroll Servers,
this is a valid set up.

When the Proxy becomes available, the next Discovery iteration will
correctly enroll servers.
mmcallister pushed a commit that referenced this pull request Nov 6, 2025
If teleport is started with just Auth and Discovery in the same host,
the Public Proxy Addr is not available.

Even tho this means that Discovery will not be able to enroll Servers,
this is a valid set up.

When the Proxy becomes available, the next Discovery iteration will
correctly enroll servers.
mmcallister pushed a commit that referenced this pull request Nov 19, 2025
If teleport is started with just Auth and Discovery in the same host,
the Public Proxy Addr is not available.

Even tho this means that Discovery will not be able to enroll Servers,
this is a valid set up.

When the Proxy becomes available, the next Discovery iteration will
correctly enroll servers.
mmcallister pushed a commit that referenced this pull request Nov 20, 2025
If teleport is started with just Auth and Discovery in the same host,
the Public Proxy Addr is not available.

Even tho this means that Discovery will not be able to enroll Servers,
this is a valid set up.

When the Proxy becomes available, the next Discovery iteration will
correctly enroll servers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/branch/v18 discovery no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants