Fix WebUI SSH sessions in Proxy Recording mode#60299
Merged
Conversation
Joerger
changed the title
Joerger
force-pushed
the
joerger/fix-proxy-rec-webui
branch
from
dacd6c6 to
2edc575
Compare
cthach
approved these changes
Oct 17, 2025
Contributor
cthach
left a comment
cthach
left a comment
There was a problem hiding this comment.
Great detective work and well done. I seriously appreciate that you took the time to write a really good PR description, which helped me understand the problem and solution quickly.
rosstimothy
approved these changes
Oct 17, 2025
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
Confirming that I've manually tested that sessions established in the UI are functional with this change.
public-teleport-github-review-bot
bot
removed request for
bernardjkim and
nklaassen
Contributor
This was referenced Oct 17, 2025
mmcallister
pushed a commit
that referenced
this pull request
Nov 6, 2025
* Set AddKeysToAgent to no for WebUI clients; Remove unused code. * Fix Signers method which overwrites local agent keys with system agent keys. * Add test.
mmcallister
pushed a commit
that referenced
this pull request
Nov 19, 2025
* Set AddKeysToAgent to no for WebUI clients; Remove unused code. * Fix Signers method which overwrites local agent keys with system agent keys. * Add test.
mmcallister
pushed a commit
that referenced
this pull request
Nov 20, 2025
* Set AddKeysToAgent to no for WebUI clients; Remove unused code. * Fix Signers method which overwrites local agent keys with system agent keys. * Add test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fixed a bug in Proxy Recording Mode that causes SSH sessions in the WebUI to fail.
In #54227, we began to set
client.AddKeysToAgent = "auto"by default instead of setting it to"". This broke the WebUI with Proxy Recording mode. Since the system agent is not relevant to the WebUI, I'ved updated the WebUI client to explicitly setAddKeysToAgent = no.The root cause of this breakage (which I've added a test for) is actually from #17610, where
keyagent.Signersoverwrote the signers from the local agent with the signers in the key agent. In the case of the WebUI, the client key is never actually loaded into the system agent, only manually loaded into the local agent, so this overwrite results in 0 signers, rather than the redundant, duplicate signers expected.Note: if you
tsh loginand add the keys to your system agent, then you would bypass the bug, as your system agent keys would be used by the WebUI.Fixes #60295