-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[mcp] Web UI and Teleport Connect adjustments for SSE and Streamable HTTP MCP servers #60281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /** | ||
| * Teleport | ||
| * Copyright (C) 2025 Gravitational, Inc. | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU Affero General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU Affero General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Affero General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| import { getAppProtocol, getAppUriScheme } from './apps'; | ||
| import type { AppProtocol } from './types'; | ||
|
|
||
| describe('getAppProtocol', () => { | ||
| test.each<[string, AppProtocol]>([ | ||
| // TCP | ||
| ['tcp://localhost:8080', 'TCP'], | ||
|
|
||
| // MCP | ||
| ['mcp+stdio://', 'MCP'], | ||
| ['mcp+http://example.com/mcp', 'MCP'], | ||
| ['mcp+sse+https://example.com/sse', 'MCP'], | ||
|
|
||
| // HTTP (fallback/default) | ||
| ['http://localhost:8080', 'HTTP'], | ||
| ['https://localhost:8080', 'HTTP'], | ||
| ['cloud://AWS', 'HTTP'], | ||
| ])('%s is %s', (uri, expected) => { | ||
| expect(getAppProtocol(uri)).toBe(expected); | ||
| }); | ||
| }); | ||
|
|
||
| describe('getAppUriScheme', () => { | ||
| test.each<[string, string]>([ | ||
| ['tcp://localhost:8080', 'tcp'], | ||
| ['https://localhost:8080', 'https'], | ||
| ['mcp+http://example.com/mcp', 'mcp+http'], | ||
| ['', ''], | ||
| ])('scheme from %s is %s', (uri, expected) => { | ||
| expect(getAppUriScheme(uri)).toBe(expected); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -43,8 +43,10 @@ import { | |||||
| MenuLoginProps, | ||||||
| } from 'shared/components/MenuLogin'; | ||||||
| import { MenuLoginWithActionMenu } from 'shared/components/MenuLoginWithActionMenu'; | ||||||
| import { getAppProtocol } from 'shared/services/apps'; | ||||||
|
|
||||||
| import { | ||||||
| doesMcpAppSupportGateway, | ||||||
| formatPortRange, | ||||||
| getAwsAppLaunchUrl, | ||||||
| getSamlAppSsoUrl, | ||||||
|
|
@@ -178,6 +180,7 @@ export function ConnectAppActionButton(props: { app: App }): React.JSX.Element { | |||||
| setUpAppGateway(appContext, props.app.uri, { | ||||||
| telemetry: { origin: 'resource_table' }, | ||||||
| targetPort, | ||||||
| targetProtocol: getAppProtocol(props.app.endpointUri), | ||||||
| }); | ||||||
| } | ||||||
|
|
||||||
|
|
@@ -326,7 +329,20 @@ function AppButton(props: { | |||||
| } | ||||||
|
|
||||||
| if (isMcp(props.app)) { | ||||||
| // TODO(greedy52) decide what to do with MCP servers. | ||||||
| // Streamable HTTP MCP servers support local proxy gateway. | ||||||
| if (doesMcpAppSupportGateway(props.app)) { | ||||||
| return ( | ||||||
| <ButtonBorder | ||||||
| size="small" | ||||||
| onClick={() => props.setUpGateway()} | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i get a type check error on this: |
||||||
| textTransform="none" | ||||||
| width={buttonWidth} | ||||||
| > | ||||||
| Connect | ||||||
| </ButtonBorder> | ||||||
| ); | ||||||
| } | ||||||
| // TODO(greedy52) decide what to do with MCP servers that don't support gateway. | ||||||
| // In the meantime, display a box of specific width to make the other columns line up for MCP | ||||||
| // apps in the list view of unified resources. | ||||||
| return <Box width={buttonWidth} />; | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, I assume VNet support is out of the question for now because VNet only supports TCP apps, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, it's not supported at the moment. We could technically support it in VNET and make MCP clients always connect as
http(nothttps).However, we are likely working on this later this Q:
#57882
Once we have that, we might deprecate existing connection methods.